fediversity/fediversity
13
2
Fork 6
Code Issues 121 Pull requests 17 Projects 1 Activity Actions

set default value for nixops4Package #412

Merged
kiara merged 6 commits from kiara/Fediversity:default-nixops-package into main 2025-06-30 12:44:55 +02:00
Conversation 2 Commits 6 Files changed 6 +17 -6
kiara commented 2025-06-27 13:32:24 +02:00
Owner
Copy link
No description provided.
fricklerhandwerk was assigned by kiara 2025-06-27 13:32:24 +02:00
Niols was assigned by kiara 2025-06-27 13:32:24 +02:00
kiara added 1 commit 2025-06-27 13:32:25 +02:00
set default value for nixops4Package
All checks were successful
/ check-pre-commit (pull_request) Successful in 14s
Details
/ check-data-model (pull_request) Successful in 26s
Details
/ check-peertube (pull_request) Successful in 19s
Details
/ check-panel (pull_request) Successful in 1m21s
Details
/ check-deployment-basic (pull_request) Successful in 11m21s
Details
/ check-deployment-cli (pull_request) Successful in 39m28s
Details
/ check-deployment-panel (pull_request) Successful in 42m46s
Details
fb8957eb86
kiara added a new dependency 2025-06-27 13:34:45 +02:00
#389 Add forgejo-ci machine to our infrastructure
fricklerhandwerk reviewed 2025-06-27 14:08:49 +02:00
panel/nix/configuration.nix Outdated
@ -150,0 +160,4 @@
;
inherit (inputs) nixops4;
in
(load-flake nixops4).packages.${pkgs.system}.default;
fricklerhandwerk commented 2025-06-27 14:08:49 +02:00
Owner
Copy link

why don't we instead splice it in through the overlay? it will reduce to pkgs.nixops4 here, source wrangling will happen in panel/default.nix (before we merge it with default.nix) where it belongs, and the overlay is the correct place to add additional stuff to pkgs.

why don't we instead splice it in through the overlay? it will reduce to `pkgs.nixops4` here, source wrangling will happen in `panel/default.nix` (before we merge it with `default.nix`) where it belongs, and the overlay is the correct place to add additional stuff to `pkgs`.
fricklerhandwerk commented 2025-06-27 14:10:40 +02:00
Owner
Copy link

PS: IMO ../. is a code smell in the Nix language, and I recommend using it as an indicator to reconsider where to put things and how to pass them through.

PS: IMO `../.` is a code smell in the Nix language, and I recommend using it as an indicator to reconsider where to put things and how to pass them through.
kiara commented 2025-06-27 15:30:36 +02:00
Author
Owner
Copy link

thanks, i moved it to the overlay now.

on paths like that, agreed (see #346). in this case tho, given the path targets the root-level flake path, what would you propose?

thanks, i moved it to the overlay now. on paths like that, agreed (see #346). in this case tho, given the path targets the root-level flake path, what would you propose?
❤️ 1
fricklerhandwerk commented 2025-06-30 12:24:59 +02:00
Owner
Copy link

I'd propose to gradually rework the whole setup, as discussed last week; essentially modularize everything, just not with flake-parts, because there's no reason whatsoever to produce flake outputs. But there's very good reason to pass around values through module options and have some type safety (both for reducing opportunity for error and readability).

I'd propose to gradually rework the whole setup, as discussed last week; essentially modularize everything, just not with flake-parts, because there's no reason whatsoever to produce flake outputs. But there's very good reason to pass around values through module options and have some type safety (both for reducing opportunity for error and readability).
👍 1
kiara force-pushed default-nixops-package from fb8957eb86 to 33bc802c21 2025-06-27 14:43:24 +02:00 Compare
kiara added 1 commit 2025-06-27 14:47:41 +02:00
move nixops4 to overlay
All checks were successful
/ check-pre-commit (pull_request) Successful in 13s
Details
/ check-data-model (pull_request) Successful in 27s
Details
/ check-peertube (pull_request) Successful in 20s
Details
/ check-panel (pull_request) Successful in 1m22s
Details
/ check-deployment-basic (pull_request) Successful in 11m31s
Details
/ check-deployment-cli (pull_request) Successful in 37m33s
Details
/ check-deployment-panel (pull_request) Successful in 41m19s
Details
c532076bc0
kiara added 1 commit 2025-06-27 15:57:27 +02:00
use default nixops4 package in panel/nix/tests.nix
All checks were successful
/ check-pre-commit (pull_request) Successful in 13s
Details
/ check-data-model (pull_request) Successful in 26s
Details
/ check-peertube (pull_request) Successful in 20s
Details
/ check-panel (pull_request) Successful in 1m32s
Details
/ check-deployment-basic (pull_request) Successful in 11m33s
Details
/ check-deployment-cli (pull_request) Successful in 38m44s
Details
/ check-deployment-panel (pull_request) Successful in 43m34s
Details
27fb134baa
kiara added 1 commit 2025-06-27 16:12:34 +02:00
add nixops4 to panel shell, follow-up to #411, reverting the now-obsolete #406
All checks were successful
/ check-pre-commit (pull_request) Successful in 13s
Details
/ check-data-model (pull_request) Successful in 26s
Details
/ check-peertube (pull_request) Successful in 20s
Details
/ check-panel (pull_request) Successful in 1m30s
Details
/ check-deployment-basic (pull_request) Successful in 11m27s
Details
/ check-deployment-cli (pull_request) Successful in 38m16s
Details
/ check-deployment-panel (pull_request) Successful in 41m21s
Details
3f0f73ef6e
kiara added 1 commit 2025-06-27 16:15:06 +02:00
always settle for default nixops4 package
All checks were successful
/ check-pre-commit (pull_request) Successful in 13s
Details
/ check-data-model (pull_request) Successful in 26s
Details
/ check-peertube (pull_request) Successful in 20s
Details
/ check-panel (pull_request) Successful in 1m32s
Details
/ check-deployment-basic (pull_request) Successful in 11m36s
Details
/ check-deployment-cli (pull_request) Successful in 39m36s
Details
/ check-deployment-panel (pull_request) Successful in 42m0s
Details
5a1ac8ee8f
fricklerhandwerk approved these changes 2025-06-30 12:18:17 +02:00
fricklerhandwerk reviewed 2025-06-30 12:19:07 +02:00
fricklerhandwerk added 1 commit 2025-06-30 12:22:47 +02:00
load-flake isn't needed
All checks were successful
/ check-pre-commit (pull_request) Successful in 14s
Details
/ check-data-model (pull_request) Successful in 27s
Details
/ check-peertube (pull_request) Successful in 20s
Details
/ check-panel (pull_request) Successful in 1m29s
Details
/ check-deployment-basic (pull_request) Successful in 11m6s
Details
/ check-deployment-cli (pull_request) Successful in 38m46s
Details
/ check-deployment-panel (pull_request) Successful in 42m39s
Details
8233326bf8
fricklerhandwerk commented 2025-06-30 12:23:13 +02:00
Owner
Copy link

Nice, clean change :)

Nice, clean change :)
kiara merged commit 737aecaba6 into main 2025-06-30 12:44:55 +02:00
kiara deleted branch default-nixops-package 2025-06-30 12:44:55 +02:00
Niols commented 2025-06-30 14:34:12 +02:00
Owner
Copy link

Amazing!

Amazing!
🎉 1
fricklerhandwerk referenced this pull request from a commit 2025-06-30 15:11:38 +02:00
Document why Nix and OpenSSH
Sign in to join this conversation.
Reviewers
No reviewers
fricklerhandwerk
Labels
Clear labels   
api service

features that may relate more to a (to be created) API service

  
blocked

   
bug

Anything that doesn't work as advertised

  
component: fediversity panel

   
component: nixops4

   
documentation

   
estimation high: >3d

   
estimation low: <2h

   
estimation mid: <8h

   
productisation

features out-scoped with the decoupling of the productisation effort

  
project-management

Project management related tasks

  
question

   
role: application developer

   
role: application operator

   
role: hosting provider

   
role: maintainer

   
security

   
technical debt

   
testing

   
type unclear

   
type: key result

   
type: objective

   
type: task

   
type: user story

   
user experience
No labels
api service
blocked
bug
component: fediversity panel
component: nixops4
documentation
estimation high: >3d
estimation low: <2h
estimation mid: <8h
productisation
project-management
question
role: application developer
role: application operator
role: hosting provider
role: maintainer
security
technical debt
testing
type unclear
type: key result
type: objective
type: task
type: user story
user experience
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
fricklerhandwerk
Niols
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#389 Add forgejo-ci machine to our infrastructure}
fediversity/fediversity
Reference: fediversity/fediversity#412
No description provided.
Delete branch "kiara/Fediversity:default-nixops-package"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?