set default value for nixops4Package #412

Merged
kiara merged 6 commits from kiara/fediversity:default-nixops-package into main 2025-06-30 12:44:55 +02:00
Owner
No description provided.
@ -150,0 +160,4 @@
;
inherit (inputs) nixops4;
in
(load-flake nixops4).packages.${pkgs.system}.default;

why don't we instead splice it in through the overlay? it will reduce to pkgs.nixops4 here, source wrangling will happen in panel/default.nix (before we merge it with default.nix) where it belongs, and the overlay is the correct place to add additional stuff to pkgs.

why don't we instead splice it in through the overlay? it will reduce to `pkgs.nixops4` here, source wrangling will happen in `panel/default.nix` (before we merge it with `default.nix`) where it belongs, and the overlay is the correct place to add additional stuff to `pkgs`.

PS: IMO ../. is a code smell in the Nix language, and I recommend using it as an indicator to reconsider where to put things and how to pass them through.

PS: IMO `../.` is a code smell in the Nix language, and I recommend using it as an indicator to reconsider where to put things and how to pass them through.
Author
Owner

thanks, i moved it to the overlay now.

on paths like that, agreed (see #346). in this case tho, given the path targets the root-level flake path, what would you propose?

thanks, i moved it to the overlay now. on paths like that, agreed (see #346). in this case tho, given the path targets the root-level flake path, what would you propose?

I'd propose to gradually rework the whole setup, as discussed last week; essentially modularize everything, just not with flake-parts, because there's no reason whatsoever to produce flake outputs. But there's very good reason to pass around values through module options and have some type safety (both for reducing opportunity for error and readability).

I'd propose to gradually rework the whole setup, as discussed last week; essentially modularize everything, just not with flake-parts, because there's no reason whatsoever to produce flake outputs. But there's very good reason to pass around values through module options and have some type safety (both for reducing opportunity for error and readability).
kiara force-pushed default-nixops-package from fb8957eb86
All checks were successful
/ check-pre-commit (pull_request) Successful in 14s
/ check-data-model (pull_request) Successful in 26s
/ check-peertube (pull_request) Successful in 19s
/ check-panel (pull_request) Successful in 1m21s
/ check-deployment-basic (pull_request) Successful in 11m21s
/ check-deployment-cli (pull_request) Successful in 39m28s
/ check-deployment-panel (pull_request) Successful in 42m46s
to 33bc802c21
All checks were successful
/ check-pre-commit (pull_request) Successful in 14s
/ check-data-model (pull_request) Successful in 26s
/ check-peertube (pull_request) Successful in 19s
/ check-panel (pull_request) Successful in 1m21s
/ check-deployment-basic (pull_request) Successful in 11m26s
/ check-deployment-cli (pull_request) Successful in 38m0s
/ check-deployment-panel (pull_request) Successful in 43m5s
2025-06-27 14:43:24 +02:00
Compare
move nixops4 to overlay
All checks were successful
/ check-pre-commit (pull_request) Successful in 13s
/ check-data-model (pull_request) Successful in 27s
/ check-peertube (pull_request) Successful in 20s
/ check-panel (pull_request) Successful in 1m22s
/ check-deployment-basic (pull_request) Successful in 11m31s
/ check-deployment-cli (pull_request) Successful in 37m33s
/ check-deployment-panel (pull_request) Successful in 41m19s
c532076bc0
use default nixops4 package in panel/nix/tests.nix
All checks were successful
/ check-pre-commit (pull_request) Successful in 13s
/ check-data-model (pull_request) Successful in 26s
/ check-peertube (pull_request) Successful in 20s
/ check-panel (pull_request) Successful in 1m32s
/ check-deployment-basic (pull_request) Successful in 11m33s
/ check-deployment-cli (pull_request) Successful in 38m44s
/ check-deployment-panel (pull_request) Successful in 43m34s
27fb134baa
add nixops4 to panel shell, follow-up to #411, reverting the now-obsolete #406
All checks were successful
/ check-pre-commit (pull_request) Successful in 13s
/ check-data-model (pull_request) Successful in 26s
/ check-peertube (pull_request) Successful in 20s
/ check-panel (pull_request) Successful in 1m30s
/ check-deployment-basic (pull_request) Successful in 11m27s
/ check-deployment-cli (pull_request) Successful in 38m16s
/ check-deployment-panel (pull_request) Successful in 41m21s
3f0f73ef6e
always settle for default nixops4 package
All checks were successful
/ check-pre-commit (pull_request) Successful in 13s
/ check-data-model (pull_request) Successful in 26s
/ check-peertube (pull_request) Successful in 20s
/ check-panel (pull_request) Successful in 1m32s
/ check-deployment-basic (pull_request) Successful in 11m36s
/ check-deployment-cli (pull_request) Successful in 39m36s
/ check-deployment-panel (pull_request) Successful in 42m0s
5a1ac8ee8f
load-flake isn't needed
All checks were successful
/ check-pre-commit (pull_request) Successful in 14s
/ check-data-model (pull_request) Successful in 27s
/ check-peertube (pull_request) Successful in 20s
/ check-panel (pull_request) Successful in 1m29s
/ check-deployment-basic (pull_request) Successful in 11m6s
/ check-deployment-cli (pull_request) Successful in 38m46s
/ check-deployment-panel (pull_request) Successful in 42m39s
8233326bf8

Nice, clean change :)

Nice, clean change :)
kiara merged commit 737aecaba6 into main 2025-06-30 12:44:55 +02:00
kiara deleted branch default-nixops-package 2025-06-30 12:44:55 +02:00
Owner

Amazing!

Amazing!
fricklerhandwerk referenced this pull request from a commit 2025-06-30 15:11:38 +02:00
Sign in to join this conversation.
No reviewers
No milestone
No project
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
fediversity/fediversity!412
No description provided.