fediversity/fediversity
13
2
Fork 6
Code Issues 157 Pull requests 29 Projects 1 Activity Actions

Add forgejo-ci machine to our infrastructure #389

Merged
kiara merged 2 commits from kiara/fediversity:forgejo-ci into main 2025-07-02 17:43:11 +02:00
Conversation 7 Commits 2 Files changed 9 +122 -6
kiara commented 2025-06-17 18:43:26 +02:00
Owner
Copy link

picked up from https://git.fediversity.eu/Fediversity/Fediversity/compare/main...niols:forgejo-ci.

closes #356.

picked up from https://git.fediversity.eu/Fediversity/Fediversity/compare/main...niols:forgejo-ci. closes #356.
kiara changed title from WIP: forgejo-ci to forgejo-ci 2025-06-19 10:25:18 +02:00
requested reviews from fricklerhandwerk, Niols 2025-06-19 18:10:48 +02:00
fricklerhandwerk commented 2025-06-20 12:05:46 +02:00
Owner
Copy link

This is a bit too much for me to follow, we should walk through the state and diff in a pairing session.

This is a bit too much for me to follow, we should walk through the state and diff in a pairing session.
👍 1
Niols reviewed 2025-06-25 18:56:47 +02:00
infra/forgejo-ci/flake-part.nix Outdated
@ -0,0 +30,4 @@
host = "45.142.234.216";
opts = "-J orianne"; # FIXME
hostPublicKey = hostPublicKey;
};
Niols commented 2025-06-25 18:56:47 +02:00
Owner
Copy link

This is a bit of a problem, and IIRC it was one of the main reasons not to merge at the time:

ssh -J orianne 45.142.234.216

will not work for anyone but me. I suppose a solution would be to just use host = "forgejo-ci" and remove opts, and leave each user configure what to do to reach it in their own .ssh/config.

This is a bit of a problem, and IIRC it was one of the main reasons not to merge at the time: ``` ssh -J orianne 45.142.234.216 ``` will not work for anyone but me. I suppose a solution would be to just use `host = "forgejo-ci"` and remove `opts`, and leave each user configure what to do to reach it in their own `.ssh/config`.
kiara marked this conversation as resolved
Niols commented 2025-06-25 18:58:44 +02:00
Owner
Copy link

This contains a bunch of different things. I think we could extract smaller PRs, eg.:

  • strip the changes to the panel away (what are they doing in here?)
  • a first piece of work updating infra/common and the existing machines
  • a second piece of work adding forgejo-ci
This contains a bunch of different things. I think we could extract smaller PRs, eg.: - strip the changes to the panel away (what are they doing in here?) - a first piece of work updating `infra/common` and the existing machines - a second piece of work adding `forgejo-ci`
👍 1
fricklerhandwerk reviewed 2025-07-01 10:40:07 +02:00
infra/forgejo-ci/flake-part.nix Outdated
@ -0,0 +9,4 @@
inherit (lib.attrsets) concatMapAttrs optionalAttrs;
inherit (lib.strings) removeSuffix;
secretsPrefix = ../../secrets;
fricklerhandwerk commented 2025-07-01 10:40:07 +02:00
Owner
Copy link

Let's maybe put sources, secrets, keys into _module.args at the evaluation entry point, or even better, some global option as the module gods intended?

Let's maybe put `sources`, `secrets`, `keys` into `_module.args` at the evaluation entry point, or even better, some global option as the module gods intended?
Niols commented 2025-07-01 13:22:49 +02:00
Owner
Copy link

For sources, this is partially tackled by Fediversity/Fediversity#421.

For `sources`, this is partially tackled by https://git.fediversity.eu/Fediversity/Fediversity/pulls/421.
👍 1
kiara marked this conversation as resolved
Niols reviewed 2025-07-02 13:07:28 +02:00
infra/flake-part.nix Outdated
@ -169,1 +169,4 @@
# NOTE: `forgejo-ci`, being a physical machine and not a Proxmox VM, gets
# custom treatment.
imports = [ ./forgejo-ci/flake-part.nix ];
Niols commented 2025-07-02 13:07:28 +02:00
Owner
Copy link

Is the treatment really that specific that it needs to get its own flake-part.nix and its own deployment and all?

Is the treatment really that specific that it needs to get its own `flake-part.nix` and its own deployment and all?
kiara marked this conversation as resolved
Niols approved these changes 2025-07-02 13:08:00 +02:00
Niols left a comment
Owner
Copy link

LGTM! Shouldn't we move it to machines/dev instead of having it in infra?

LGTM! Shouldn't we move it to `machines/dev` instead of having it in `infra`?
👍 1
Niols changed title from forgejo-ci to Add forgejo-ci machine to our infrastructure 2025-07-02 13:08:18 +02:00
kiara changed title from Add forgejo-ci machine to our infrastructure to WIP: Add forgejo-ci machine to our infrastructure 2025-07-02 13:11:36 +02:00
kiara changed title from WIP: Add forgejo-ci machine to our infrastructure to Add forgejo-ci machine to our infrastructure 2025-07-02 14:59:32 +02:00
kiara commented 2025-07-02 15:01:50 +02:00
Author
Owner
Copy link

thanks for your feedback @Niols, i've updated the PR to incorporate it now. would you mind reviewing?

edit: for reference, i have in fact gotten the deployment working now.

thanks for your feedback @Niols, i've updated the PR to incorporate it now. would you mind reviewing? edit: for reference, i have in fact gotten the deployment working now.
kiara merged commit 871672d447 into main 2025-07-02 17:43:11 +02:00
kiara deleted branch forgejo-ci 2025-07-02 17:43:12 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
fricklerhandwerk
Niols
Labels
Clear labels   
0 points

fibonacci complexity: 0 points

  
0.5 points

fibonacci complexity: 0.5 points

  
1 point

fibonacci complexity: 1 point

  
13 points

fibonacci complexity: 13 points

  
2 points

fibonacci complexity: 2 points

  
21 points

fibonacci complexity: 21 points

  
3 points

fibonacci complexity: 3 points

  
34 points

fibonacci complexity: 34 points

  
5 points

fibonacci complexity: 5 points

  
55 points

fibonacci complexity: 55 points

  
8 points

fibonacci complexity: 8 points

  
api service

features that may relate more to a (to be created) API service

  
blocked

   
component: fediversity panel

   
component: nixops4

   
documentation

   
estimation high: >3d

   
estimation low: <2h

   
estimation mid: <8h

   
infinite points

fibonacci complexity: infinite points

  
productisation

features out-scoped with the decoupling of the productisation effort

  
project-management

Project management related tasks

  
question

   
role: application developer

   
role: application operator

   
role: hosting provider

   
role: maintainer

   
security

   
technical debt

   
testing

   
type unclear

   
type: bug

Anything that doesn't work as advertised

  
type: deliverable

   
type: key result

   
type: objective

   
type: task

   
type: user story

   
user experience
No labels
0 points
0.5 points
1 point
13 points
2 points
21 points
3 points
34 points
5 points
55 points
8 points
api service
blocked
component: fediversity panel
component: nixops4
documentation
estimation high: >3d
estimation low: <2h
estimation mid: <8h
infinite points
productisation
project-management
question
role: application developer
role: application operator
role: hosting provider
role: maintainer
security
technical debt
testing
type unclear
type: bug
type: deliverable
type: key result
type: objective
type: task
type: user story
user experience
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Depends on
#412 set default value for nixops4Package
fediversity/fediversity
#413 allow configuring network interface
fediversity/fediversity
#414 allow configuring whether a node uses QEMU
fediversity/fediversity
Reference: fediversity/fediversity#389
No description provided.
Delete branch "kiara/fediversity:forgejo-ci"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?