Fediversity/Fediversity
7
0
Fork 3
Code Issues 16 Pull requests 2 Actions Projects 1 Activity

Flake environment with pre-commit hook; CI to enforce them. #2

Merged
Niols merged 4 commits from pre-commit-and-ci into main 2024-11-14 17:51:17 +01:00
Conversation 1 Commits 4 Files changed 14 +239 -57
Niols commented 2024-11-14 01:30:51 +01:00
Owner
Copy link

This PR introduces a basic flake environment and a basic CI. The flake contains very little; basically only a pre-commit hook for Nix formatting and Nix dead code detection. The CI only enforces those. This is meant as a building stone for other later PRs.

This PR introduces a basic flake environment and a basic CI. The flake contains very little; basically only a pre-commit hook for Nix formatting and Nix dead code detection. The CI only enforces those. This is meant as a building stone for other later PRs.
Niols added 3 commits 2024-11-14 01:30:52 +01:00
Niols added 1 commit 2024-11-14 09:50:22 +01:00
Niols added 1 commit 2024-11-14 09:51:05 +01:00
fricklerhandwerk approved these changes 2024-11-14 10:56:25 +01:00
fricklerhandwerk left a comment
Owner
Copy link

Works. Shameless plug, because I think pre-commit is quite slow and needlessly complex: I've wrote a very thin Nix layer around setting Git hooks directly, which can be combined with treefmt-nix. Maybe for one day. (My thing still needs options to do more hooks than just pre-commit)

Works. Shameless plug, because I think pre-commit is quite slow and needlessly complex: I've wrote [a very thin Nix layer around setting Git hooks directly](https://github.com/fricklerhandwerk/git-hooks), which can be combined with [treefmt-nix](https://github.com/numtide/treefmt-nix/). Maybe for one day. (My thing still needs options to do more hooks than just pre-commit)
Niols commented 2024-11-14 11:29:25 +01:00
Author
Owner
Copy link

Ooh, that would be nice, because I agree with the statement that “pre-commit is quite slow and needlessly complex”. I will not merge the PR right away because, somehow, the CI is not triggering, and I don't understand why. It might be just a Forgejo repository configuration issue, because it previously worked in Fediversity/simple-nixos-fediverse#25. I will investigate.

Ooh, that would be nice, because I agree with the statement that “pre-commit is quite slow and needlessly complex”. I will not merge the PR right away because, somehow, the CI is not triggering, and I don't understand why. It might be just a Forgejo repository configuration issue, because it previously worked in https://git.fediversity.eu/Fediversity/simple-nixos-fediverse/pulls/25. I will investigate.
Niols force-pushed pre-commit-and-ci from 0bcaf844a4 to a888540580 2024-11-14 17:50:31 +01:00 Compare
Niols merged commit 7ac8ec85cc into main 2024-11-14 17:51:17 +01:00
Niols deleted branch pre-commit-and-ci 2024-11-14 17:51:19 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
fricklerhandwerk
Labels
Clear labels   
blocked

   
project-management

Project management related tasks

  
question
No labels
blocked
project-management
question
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Fediversity/Fediversity#2
No description provided.
Delete branch "pre-commit-and-ci"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?