Fediversity/Fediversity
12
2
Fork 6
Code Issues 86 Pull requests 3 Projects 1 Activity Actions

remove trailing whitespace from deployment/README.md #171

Merged
kiara merged 1 commit from kiara/Fediversity:rm-trailing-whitespace into main 2025-02-20 15:11:34 +01:00
Conversation 6 Commits 1 Files changed 1 +1 -1
kiara commented 2025-02-20 15:05:54 +01:00
Owner
Copy link
No description provided.
fricklerhandwerk was assigned by kiara 2025-02-20 15:05:54 +01:00
kevin was assigned by kiara 2025-02-20 15:05:54 +01:00
lois was assigned by kiara 2025-02-20 15:05:54 +01:00
Niols was assigned by kiara 2025-02-20 15:05:54 +01:00
kiara added 1 commit 2025-02-20 15:05:56 +01:00
remove trailing whitespace from deployment/README.md
All checks were successful
/ check-pre-commit (pull_request) Successful in 25s
Details
/ check-website (pull_request) Successful in 10s
Details
/ check-peertube (pull_request) Successful in 21s
Details
a4961f3863
kiara changed title from $(git log --pretty=%s | head -n 1) to remove trailing whitespace from deployment/README.md 2025-02-20 15:10:21 +01:00
kevin approved these changes 2025-02-20 15:11:12 +01:00
kevin left a comment
Owner
Copy link

lgtm

lgtm
kiara merged commit 1df61bbe4d into main 2025-02-20 15:11:34 +01:00
kiara deleted branch rm-trailing-whitespace 2025-02-20 15:11:35 +01:00
Niols commented 2025-02-20 15:50:57 +01:00
Owner
Copy link

I'm curious - do we know how it got there in the first place?

I'm curious - do we know how it got there in the first place?
kiara commented 2025-02-20 16:01:41 +01:00
Author
Owner
Copy link

@Niols: tl;dr it's on me.

going by the commit list, the first offending commit was the merge of #166, whereas that PR originally showed a green CI.
i believe that one went bad since rebasing on 142af8d0ee, while yours truly turned out too impatient to await CI rerunning after a rebase on what seemed an innocuous PR that had seemed green already.

/cc @fricklerhandwerk

@Niols: tl;dr it's on me. going by the [commit list](https://git.fediversity.eu/Fediversity/Fediversity/commits/branch/main), the first offending commit was the merge of #166, whereas that PR originally showed a green CI. i believe that one went bad since rebasing on 142af8d0ee43a692e64e57e6cab8dc198f397f55, while yours truly turned out too impatient to await CI rerunning after a rebase on what seemed an innocuous PR that had seemed green already. /cc @fricklerhandwerk
Niols commented 2025-02-20 16:09:04 +01:00
Owner
Copy link

Ah yes, fair enough. I don't think it's on you, I think it's on branch protection rules not doing their job here; you shouldn't be able to merge a PR where CI isn't green without checking a big “I UNDERSTAND THE RISKS” box.

Ah yes, fair enough. I don't think it's on you, I think it's on branch protection rules not doing their job here; you shouldn't be able to merge a PR where CI isn't green without checking a big “I UNDERSTAND THE RISKS” box.
kiara commented 2025-02-20 16:59:51 +01:00
Author
Owner
Copy link

i did check such a box 🙈

i did check such a box 🙈
Niols commented 2025-02-20 18:47:37 +01:00
Owner
Copy link

Hehe, nevermind then!

Hehe, nevermind then!
Niols commented 2025-02-20 18:48:08 +01:00
Owner
Copy link

If you're using the dev environment from the flake, it should also prevent you from making such commits in the first place.

If you're using the dev environment from the flake, it should also prevent you from making such commits in the first place.
❤️ 1
Sign in to join this conversation.
Reviewers
No reviewers
kevin
Labels
Clear labels   
blocked

   
bug

Anything that doesn't work as advertised

  
contributor experience

   
devops

   
documentation

   
estimation high: >3d

   
estimation low: <2h

   
estimation mid: <8h

   
fediversity panel

   
project-management

Project management related tasks

  
question

   
security

   
sysadmin

   
testing

   
user experience

   
user story
No labels
blocked
bug
contributor experience
devops
documentation
estimation high: >3d
estimation low: <2h
estimation mid: <8h
fediversity panel
project-management
question
security
sysadmin
testing
user experience
user story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
fricklerhandwerk
kevin
lois
Niols
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Fediversity/Fediversity#171
No description provided.
Delete branch "kiara/Fediversity:rm-trailing-whitespace"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?