kiara Grouwstra kiara · any pronouns
kiara commented on issue Fediversity/Fediversity#75 2025-02-19 13:27:18 +01:00
Receive a notification when deployment finishes

@fricklerhandwerk how would you feel about trying this one by email for now for demo purposes? that is, until we move to css (#140) / front-end (#145) frameworks.

kiara opened issue Fediversity/Fediversity#155 2025-02-19 12:25:13 +01:00
Address CI friction between security and caching
kiara pushed to shellcheck at kiara/Fediversity 2025-02-19 12:11:15 +01:00
3addd3fd1a bash scripts: snake-case variables, deduplicate $RANDOM, satisfy LSP
kiara commented on pull request Fediversity/Fediversity#154 2025-02-19 12:02:13 +01:00
bash scripts: snake-case variables, deduplicate $RANDOM, satisfy LSP

@Niols thanks again for all the feedback - let's do that!

kiara commented on pull request Fediversity/Fediversity#154 2025-02-19 11:58:09 +01:00
bash scripts: snake-case variables, deduplicate $RANDOM, satisfy LSP

thanks, looks like i should not have assumed bash to work like TypeScript here. unfortunately, just quoting the assignment appears not to satisfy the rule (SC2155 Declare and assign separately to…

kiara pushed to shellcheck at kiara/Fediversity 2025-02-19 11:55:24 +01:00
92a7e66900 bash scripts: snake-case variables, deduplicate $RANDOM, satisfy LSP
kiara commented on pull request Fediversity/Fediversity#154 2025-02-19 11:45:33 +01:00
bash scripts: snake-case variables, deduplicate $RANDOM, satisfy LSP

apologies for not having come up with that - that one seems much nicer alright!

kiara pushed to shellcheck at kiara/Fediversity 2025-02-19 11:44:56 +01:00
eeed642dd4 bash scripts: snake-case variables, deduplicate $RANDOM, satisfy LSP
kiara pushed to shellcheck at kiara/Fediversity 2025-02-19 11:38:43 +01:00
20493966b0 bash scripts: snake-case variables, deduplicate $RANDOM, satisfy LSP
kiara commented on pull request Fediversity/Fediversity#154 2025-02-19 11:35:40 +01:00
bash scripts: snake-case variables, deduplicate $RANDOM, satisfy LSP

thanks for catching the casing inconsistency. i do see some discussion on casing…

kiara pushed to shellcheck at kiara/Fediversity 2025-02-19 11:35:24 +01:00
3e34200594 bash scripts: snake-case variables, deduplicate $RANDOM, satisfy LSP
kiara pushed to shellcheck at kiara/Fediversity 2025-02-19 11:33:11 +01:00
89ec24d534 bash scripts: snake-case variables, deduplicate $RANDOM, satisfy LSP
kiara commented on pull request Fediversity/Fediversity#154 2025-02-19 11:28:55 +01:00
bash scripts: snake-case variables, deduplicate $RANDOM, satisfy LSP

Sure - I don't doubt you had already verified any present behavior.

Now, given LSP hints that may be overly careful, our options seem:

  1. follow the advice after all
  2. add comments to…
kiara commented on pull request Fediversity/Fediversity#154 2025-02-19 10:42:43 +01:00
bash scripts: snake-case variables, deduplicate $RANDOM, satisfy LSP

I feel you. I understand the advice's point about ensuring we do not accidentally hard-code bash-y stuff. I could instead disable the particular check for this line with a comment. Would you…

kiara pushed to shellcheck at kiara/Fediversity 2025-02-19 10:31:44 +01:00
c1e51e6323 bash scripts: snake-case variables, deduplicate $RANDOM, satisfy LSP
kiara commented on pull request Fediversity/Fediversity#154 2025-02-19 10:29:54 +01:00
bash scripts: snake-case variables, deduplicate $RANDOM, satisfy LSP

the LSP had it $RANDOM is not POSIX-compliant

kiara pushed to shellcheck at kiara/Fediversity 2025-02-19 10:03:54 +01:00
a0bbfd518f bash scripts: snake-case variables, deduplicate $RANDOM, satisfy LSP
kiara commented on pull request Fediversity/Fediversity#152 2025-02-19 10:03:07 +01:00
fix syntax error

@Niols thanks, fair point. i guess right now it helps that signup on the forgejo is locked down, limiting who may run stuff in CI, tho we could also look into limiting (more) sensitive info in the…

kiara created pull request Fediversity/Fediversity#154 2025-02-19 09:45:22 +01:00
$(git log --pretty=%s