From b59f8a4183a0ce154bdb9db4441657cdf3afd672 Mon Sep 17 00:00:00 2001 From: Valentin Gagarin Date: Fri, 6 Jun 2025 10:56:34 +0200 Subject: [PATCH] simplify login tests (#352) don't go through template generation but use underlying the tag implementation directly Co-authored-by: Nicolas Jeannerod Reviewed-on: https://git.fediversity.eu/Fediversity/Fediversity/pulls/352 --- panel/src/panel/tests/test_login.py | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/panel/src/panel/tests/test_login.py b/panel/src/panel/tests/test_login.py index 8f45ae4c..9874de00 100644 --- a/panel/src/panel/tests/test_login.py +++ b/panel/src/panel/tests/test_login.py @@ -1,9 +1,10 @@ from django.test import TestCase from django.urls import reverse from django.contrib.auth.models import User -from django.template import Template, Context from urllib.parse import unquote +from panel.templatetags.custom_tags import auth_url + class Login(TestCase): def setUp(self): self.username = 'testuser' @@ -27,8 +28,7 @@ class Login(TestCase): # check that the expected login URL is in the response context = response.context[0] - template = Template("{% load custom_tags %}{% auth_url 'login' %}") - login_url = template.render(context) + login_url = auth_url(context, 'login') self.assertIn(login_url, response.content.decode('utf-8')) # log in @@ -49,8 +49,7 @@ class Login(TestCase): # check that the expected logout URL is present context = response.context[0] - template = Template("{% load custom_tags %}{% auth_url 'logout' %}") - logout_url = template.render(context) + logout_url = auth_url(context, 'logout') self.assertIn(logout_url, response.content.decode('utf-8')) # log out again @@ -88,8 +87,7 @@ class Login(TestCase): # check that the expected logout URL is present context = response.context[0] - template = Template("{% load custom_tags %}{% auth_url 'logout' %}") - logout_url = template.render(context) + logout_url = auth_url(context, 'logout') self.assertIn(logout_url, response.content.decode('utf-8')) # log out @@ -97,8 +95,7 @@ class Login(TestCase): # check that we're at the expected location, logged out self.assertEqual(response.status_code, 200) - template = Template("{% load custom_tags %}{% auth_url 'login' %}") - login_url = template.render(context) + login_url = auth_url(context, 'login') location, status = response.redirect_chain[-1] self.assertEqual(location, unquote(login_url)) self.assertFalse(response.context['user'].is_authenticated)