From 0749bda96caa94e1e5b924698a931f5d5cbe13ce Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nicolas=20=E2=80=9CNiols=E2=80=9D=20Jeannerod?=
 <nicolas.jeannerod@moduscreate.com>
Date: Wed, 20 Nov 2024 16:48:36 +0100
Subject: [PATCH] `networking.useDHCP`

---
 infra/common/networking.nix              | 5 ++++-
 infra/vm02116/hardware-configuration.nix | 4 ----
 infra/vm02179/hardware-configuration.nix | 4 ----
 infra/vm02186/hardware-configuration.nix | 4 ----
 infra/vm02187/hardware-configuration.nix | 4 ----
 5 files changed, 4 insertions(+), 17 deletions(-)

diff --git a/infra/common/networking.nix b/infra/common/networking.nix
index 49a069b..b6968c8 100644
--- a/infra/common/networking.nix
+++ b/infra/common/networking.nix
@@ -1,7 +1,7 @@
 { config, lib, ... }:
 
 let
-  inherit (lib) mkOption;
+  inherit (lib) mkOption mkDefault;
 
 in
 {
@@ -23,6 +23,9 @@ in
       hostName = config.procolix.vm.name;
       domain = "procolix.com";
 
+      ## REVIEW: Do we actually need that, considering that we have static IPs?
+      useDHCP = mkDefault true;
+
       interfaces = {
         eth0 = {
           ipv4 = {
diff --git a/infra/vm02116/hardware-configuration.nix b/infra/vm02116/hardware-configuration.nix
index 202d8bb..5ad9e85 100644
--- a/infra/vm02116/hardware-configuration.nix
+++ b/infra/vm02116/hardware-configuration.nix
@@ -1,5 +1,3 @@
-{ lib, ... }:
-
 {
   fileSystems."/" = {
     device = "/dev/disk/by-uuid/3802a66d-e31a-4650-86f3-b51b11918853";
@@ -10,6 +8,4 @@
     device = "/dev/disk/by-uuid/2CE2-1173";
     fsType = "vfat";
   };
-
-  networking.useDHCP = lib.mkDefault true;
 }
diff --git a/infra/vm02179/hardware-configuration.nix b/infra/vm02179/hardware-configuration.nix
index 391f2f9..5b89888 100644
--- a/infra/vm02179/hardware-configuration.nix
+++ b/infra/vm02179/hardware-configuration.nix
@@ -1,5 +1,3 @@
-{ lib, ... }:
-
 {
   fileSystems."/" = {
     device = "/dev/disk/by-uuid/119863f8-55cf-4e2f-ac17-27599a63f241";
@@ -14,6 +12,4 @@
       "dmask=0022"
     ];
   };
-
-  networking.useDHCP = lib.mkDefault true;
 }
diff --git a/infra/vm02186/hardware-configuration.nix b/infra/vm02186/hardware-configuration.nix
index 0ed6ebc..c9538ea 100644
--- a/infra/vm02186/hardware-configuration.nix
+++ b/infra/vm02186/hardware-configuration.nix
@@ -1,5 +1,3 @@
-{ lib, ... }:
-
 {
   fileSystems."/" = {
     device = "/dev/disk/by-uuid/833ac0f9-ad8c-45ae-a9bf-5844e378c44a";
@@ -14,6 +12,4 @@
       "dmask=0022"
     ];
   };
-
-  networking.useDHCP = lib.mkDefault true;
 }
diff --git a/infra/vm02187/hardware-configuration.nix b/infra/vm02187/hardware-configuration.nix
index 4d9eefc..c95e55d 100644
--- a/infra/vm02187/hardware-configuration.nix
+++ b/infra/vm02187/hardware-configuration.nix
@@ -1,5 +1,3 @@
-{ lib, ... }:
-
 {
   fileSystems."/" = {
     device = "/dev/disk/by-uuid/a46a9c46-e32b-4216-a4aa-8819b2cd0d49";
@@ -14,6 +12,4 @@
       "dmask=0022"
     ];
   };
-
-  networking.useDHCP = lib.mkDefault true;
 }