Valentin Gagarin fricklerhandwerk
  • Hamburg, Germany
  • Nix documentarian, information janitor

  • Joined on 2024-06-12
fricklerhandwerk commented on pull request fediversity/fediversity#481 2025-08-01 14:36:55 +02:00
Complete the data model with a runtime environment and end-to-end test

Yes I see. While I can't prove it at the moment, I think skipping the types loses us a valuable opportunity to generate rich documentation for application authors and hosting providers. And that…

fricklerhandwerk commented on pull request fediversity/fediversity#484 2025-07-31 18:09:40 +02:00
WIP: Fix and test proxmox-*.sh scripts

What about the failing tests. @kiara I remember dimly we discussed it somewhere.

fricklerhandwerk commented on pull request fricklerhandwerk/Fediversity#7 2025-07-31 18:07:13 +02:00
data model: add classes

The small changes dotting the i-s make sense, thanks a lot! The larger one not so much.

fricklerhandwerk commented on pull request fricklerhandwerk/Fediversity#7 2025-07-31 18:06:30 +02:00
data model: add classes

Very likely not needed, as noted in the other PR

fricklerhandwerk commented on pull request fricklerhandwerk/Fediversity#7 2025-07-31 18:06:12 +02:00
data model: add classes

I don't think this is an improvement in readability

fricklerhandwerk approved fricklerhandwerk/Fediversity#6 2025-07-31 17:54:16 +02:00
move nixops4Deployment class

Good catch, thank you

fricklerhandwerk commented on pull request fricklerhandwerk/Fediversity#6 2025-07-31 17:53:44 +02:00
move nixops4Deployment class

I'm not even sure this is needed at all, the import should give us that anyway

fricklerhandwerk commented on pull request fediversity/fediversity#488 2025-07-31 17:44:28 +02:00
Infra: expose and use checks for vmOptions and nixosConfigurations

Why not maAttrs'?

7ce3902851 put config stuff in an attrset
68b834b6d7 fix linter gripes
Compare 2 commits »
fricklerhandwerk merged pull request fricklerhandwerk/Fediversity#5 2025-07-31 17:36:11 +02:00
data-model linting
fricklerhandwerk commented on pull request fricklerhandwerk/Fediversity#5 2025-07-31 17:35:59 +02:00
data-model linting

Thanks!

fricklerhandwerk commented on pull request fediversity/fediversity#481 2025-07-30 14:01:24 +02:00
Complete the data model with a runtime environment and end-to-end test

ah that. but that's just a data structure you can convert to any deployment method.

fricklerhandwerk commented on pull request fediversity/fediversity#481 2025-07-30 14:00:32 +02:00
Complete the data model with a runtime environment and end-to-end test

hmm i'd say it's more about practicality. will application authors be able to work fluently with an interface that doesn't force type checks on them?

fricklerhandwerk commented on pull request fediversity/fediversity#478 2025-07-30 13:59:04 +02:00
Fix infra and add more tests

Tip: Do both. Put stuff that belongs together into nested attributes for readability, and flatten them in flake.nix so it fits the required form.

fricklerhandwerk commented on pull request fediversity/fediversity#485 2025-07-30 13:57:18 +02:00
Infra: get rid of makeResourceModule

Not sure. Depends on how much you want the directory structure to play a semantic role.

fricklerhandwerk commented on pull request fediversity/fediversity#481 2025-07-30 13:53:15 +02:00
Complete the data model with a runtime environment and end-to-end test

yes I left it to keep some intermediate diff small, will fix up...

fricklerhandwerk commented on pull request fediversity/fediversity#481 2025-07-30 13:52:45 +02:00
Complete the data model with a runtime environment and end-to-end test

yes, this is why I left the TODO to consider transposing the resource attrsOf, so we could pass just the request(s) for that same resource to this function. we supposedly wouldn't (want to) care…

fricklerhandwerk commented on pull request fediversity/fediversity#481 2025-07-30 13:50:43 +02:00
Complete the data model with a runtime environment and end-to-end test

I'm not sure I get the question. Yes, the mapping deals with the specific instance of a policy, as one can (hopefully) observe in the test, where we set the username to "operator".