forked from Fediversity/Fediversity
data model: add classes #7
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "data-model-add-classes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
specifies classes in the data model, raising these to from
_class
model attributes tosubModuleWith
'sclass
parameter where possible.note: resource policy has remained as to use
deferredModuleWith
(rather thansubmoduleWith
) to ensure evaluation will go thru.may subsume #6, in addition to superseding #4.
merge-wise, it may be preferable to handle this PR before #5.
finally, while forgejo is horrible in viewing diffs, the likes of diffchecker handle this slightly better, highlighting changed parts of lines. in practice tho, there aren't really additional changes here.
@ -132,2 +139,2 @@
description = ''
Resources made available by the hosting provider, and their policies.
type = attrsOf (submoduleWith {
class = "fediversity-environment";
I don't think this is an improvement in readability
the PR's intent was semantic rather than just documentation - even if (as noted in Fediversity/Fediversity#481 (comment)) i haven't fully grasped the full extent of
subModuleWith
'sclass
parameter.looks like a lot of that pertains to merging logic - maybe the type checks are the main thing then
@ -31,6 +33,7 @@ let
inputs.nixops4.modules.nixops4Deployment.default
{
_class = "nixops4Deployment";
Very likely not needed, as noted in the other PR
resolving until the upstream PR may supersede this, now #6 is merged
given this got merged upstream, i rebased to remove this now, ahead of our updating nixops4 (which i will consider out of scope for this PR, as i'm sure we will down the line)
The small changes dotting the i-s make sense, thanks a lot! The larger one not so much.
6cba217e53
to9f596ad820
hm, while
submoduleWith
seems to actually enforce the check, i'm now not suredeferredModuleWith
andsubmodule
function as more than documentation on this.superseded by Fediversity/Fediversity#504
Pull request closed