fricklerhandwerk/Fediversity
1
0
Fork 0
forked from fediversity/fediversity
Code Pull requests Activity

add classes #4

Closed
kiara wants to merge 1 commit from kiara/Fediversity:data-model-classes into data-model-as-diagram
pull from: kiara/Fediversity:data-model-classes
merge into: fricklerhandwerk:data-model-as-diagram
Conversation 1 Commits 1 Files changed 2 +147 -119
kiara commented 2025-07-31 16:55:53 +02:00
Contributor
Copy link

specifies classes in the data model, raising these to from _class model attributes to subModuleWith's class parameter where possible.
based on my earlier commit eba4be2b1eceff805d465ae11d69a94555d4ab88.

note: resource policy has remained as to use deferredModuleWith (rather than submoduleWith) to ensure evaluation will go thru.

merge-wise, it may be preferable to handle this PR before #3.

finally, while forgejo is horrible in viewing diffs, the likes of diffchecker handle this slightly better, highlighting changed parts of lines. in practice tho, there aren't really additional changes here.

specifies classes in the data model, raising these to from `_class` model attributes to `subModuleWith`'s `class` parameter where possible. based on my earlier commit eba4be2b1eceff805d465ae11d69a94555d4ab88. note: resource policy has remained as to use `deferredModuleWith` (rather than `submoduleWith`) to ensure evaluation will go thru. merge-wise, it may be preferable to handle this PR before #3. finally, while forgejo is horrible in viewing diffs, the likes of [diffchecker](https://www.diffchecker.com/text-compare/) handle this slightly better, highlighting changed parts of lines. in practice tho, there aren't really additional changes here.
kiara added 1 commit 2025-07-31 16:55:55 +02:00 
note: resource policy has remained as to use `deferredModuleWith`
(rather than `submoduleWith`) to ensure evaluation will go thru.
kiara commented 2025-07-31 17:30:25 +02:00
Author
Contributor
Copy link

superseded by #7

superseded by #7
kiara closed this pull request 2025-07-31 17:30:25 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: fricklerhandwerk/Fediversity#4
No description provided.
Delete branch "kiara/Fediversity:data-model-classes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?