diff --git a/panel/src/panel/views.py b/panel/src/panel/views.py index 61d4c8d8..9b1e902e 100644 --- a/panel/src/panel/views.py +++ b/panel/src/panel/views.py @@ -65,9 +65,6 @@ class ConfigurationForm(LoginRequiredMixin, APIView): config.save() return redirect(self.success_url) -# TODO(@fricklerhandwerk): -# this is broken after changing the form view. -# but if there's no test for it, how do we know it ever worked in the first place? class DeploymentStatus(ConfigurationForm): def post(self, request): @@ -84,26 +81,13 @@ class DeploymentStatus(ConfigurationForm): config.save() deployment_result, deployment_params = self.deployment(config.parsed_value) - if deployment_result.returncode == 0: - deployment_status = "Deployment Succeeded" - else: - deployment_status = "Deployment Failed" return render(self.request, "partials/deployment_result.html", { - "deployment_status": deployment_status, + "deployment_succeeded": (deployment_result.returncode == 0), "services": deployment_params.json(), }) def deployment(self, config: BaseModel): - # FIXME: let the user specify these from the form (#190) - dummy_user = { - "initialUser": { - "displayName": "Testy McTestface", - "username": "test", - "password": "testtest", - "email": "test@test.com", - }, - } env = { "PATH": settings.bin_path, # pass in form info to our deployment