checks: switch to hosting-provider terraform-backend wrapper #994

Merged
kiara merged 3 commits from kiara/fediversity:test-host-nimbolus into main 2026-05-24 08:08:28 +02:00
Owner

Have checks cover hosting-provider/terraform-backend, as part of #833.

  • Replace direct imports of src/effects/tf/common/terraform-backend.nix with the hosting-provider wrapper (src/applications/hosting-provider/terraform-backend.nix) in five checks, so tests exercise the actual hosting-provider config rather than the bare backend module.
  • Make LISTEN_ADDR, acceptTerms, and defaults.email use lib.mkDefault in the wrapper so checks can override them without mkForce.
  • Suppress the wrapper's nginx/ACME vhost in each check: four checks force-disable nginx entirely; the panel check neutralises only the tf.fediversity.eu vhost since panel uses nginx for its own router.

Test plan

  • nix build .#checks.x86_64-linux.deployment-tf-hosts
  • nix build .#checks.x86_64-linux.deployment-tf-incus-hosts
  • nix build .#checks.x86_64-linux.apps-tf
  • nix build .#checks.x86_64-linux.apps-tf-incus
  • nix build .#checks.x86_64-linux.apps-panel

Disclaimer: I used a coding agent in the creation of this patch.

Have checks cover `hosting-provider/terraform-backend`, as part of #833. - Replace direct imports of `src/effects/tf/common/terraform-backend.nix` with the hosting-provider wrapper (`src/applications/hosting-provider/terraform-backend.nix`) in five checks, so tests exercise the actual hosting-provider config rather than the bare backend module. - Make `LISTEN_ADDR`, `acceptTerms`, and `defaults.email` use `lib.mkDefault` in the wrapper so checks can override them without `mkForce`. - Suppress the wrapper's nginx/ACME vhost in each check: four checks force-disable nginx entirely; the panel check neutralises only the `tf.fediversity.eu` vhost since panel uses nginx for its own router. ## Test plan - [x] `nix build .#checks.x86_64-linux.deployment-tf-hosts` - [x] `nix build .#checks.x86_64-linux.deployment-tf-incus-hosts` - [x] `nix build .#checks.x86_64-linux.apps-tf` - [x] `nix build .#checks.x86_64-linux.apps-tf-incus` - [x] `nix build .#checks.x86_64-linux.apps-panel` Disclaimer: I used a coding agent in the creation of this patch.
kiara force-pushed test-host-nimbolus from ced34f5e1d
Some checks failed
Nix flake completeness check / _complete (pull_request) Successful in 12s
checks-deployment-nixos-hosts / deployment-nixos-hosts (pull_request) Successful in 18s
checks-apps-panel / apps-panel (pull_request) Has been cancelled
checks-deployment-tf-incus-hosts / deployment-tf-incus-hosts (pull_request) Has been cancelled
checks-pre-commit / pre-commit (pull_request) Has been cancelled
devShells-default / default (pull_request) Has been cancelled
checks-apps-tf-incus / apps-tf-incus (pull_request) Has been cancelled
flake-show / apps-ssh (pull_request) Has been cancelled
nix-unit-effects-common-lib / effects-common-lib (pull_request) Has been cancelled
nix-unit-effects-tf-common-conversion / effects-tf-common-conversion (pull_request) Has been cancelled
nix-unit-lib-data-model / lib-data-model (pull_request) Has been cancelled
checks-apps-tf / apps-tf (pull_request) Has been cancelled
nix-unit-lib-function / lib-function (pull_request) Has been cancelled
nix-unit-lib-lib / lib-lib (pull_request) Has been cancelled
nixosConfigurations-hosting-provider-combined / hosting-provider-combined (pull_request) Has been cancelled
checks-deployment-ssh-hosts / deployment-ssh-hosts (pull_request) Has been cancelled
checks-deployment-tf-hosts / deployment-tf-hosts (pull_request) Has been cancelled
nixosConfigurations-hosting-provider-terraform-backend / hosting-provider-terraform-backend (pull_request) Has been cancelled
to 6e2b4a4176
Some checks failed
Nix flake completeness check / _complete (pull_request) Successful in 11s
checks-deployment-nixos-hosts / deployment-nixos-hosts (pull_request) Successful in 39s
checks-pre-commit / pre-commit (pull_request) Has been cancelled
devShells-default / default (pull_request) Has been cancelled
checks-deployment-ssh-hosts / deployment-ssh-hosts (pull_request) Has been cancelled
flake-show / apps-ssh (pull_request) Has been cancelled
checks-apps-tf-incus / apps-tf-incus (pull_request) Has been cancelled
checks-apps-panel / apps-panel (pull_request) Has been cancelled
nix-unit-effects-common-lib / effects-common-lib (pull_request) Has been cancelled
checks-deployment-tf-incus-hosts / deployment-tf-incus-hosts (pull_request) Has been cancelled
checks-deployment-tf-hosts / deployment-tf-hosts (pull_request) Has been cancelled
checks-apps-tf / apps-tf (pull_request) Has been cancelled
nix-unit-effects-tf-common-conversion / effects-tf-common-conversion (pull_request) Has been cancelled
nix-unit-lib-data-model / lib-data-model (pull_request) Has been cancelled
nix-unit-lib-function / lib-function (pull_request) Has been cancelled
nix-unit-lib-lib / lib-lib (pull_request) Has been cancelled
nixosConfigurations-hosting-provider-combined / hosting-provider-combined (pull_request) Has been cancelled
nixosConfigurations-hosting-provider-terraform-backend / hosting-provider-terraform-backend (pull_request) Has been cancelled
2026-05-23 22:48:41 +02:00
Compare
kiara force-pushed test-host-nimbolus from 6e2b4a4176
Some checks failed
Nix flake completeness check / _complete (pull_request) Successful in 11s
checks-deployment-nixos-hosts / deployment-nixos-hosts (pull_request) Successful in 39s
checks-pre-commit / pre-commit (pull_request) Has been cancelled
devShells-default / default (pull_request) Has been cancelled
checks-deployment-ssh-hosts / deployment-ssh-hosts (pull_request) Has been cancelled
flake-show / apps-ssh (pull_request) Has been cancelled
checks-apps-tf-incus / apps-tf-incus (pull_request) Has been cancelled
checks-apps-panel / apps-panel (pull_request) Has been cancelled
nix-unit-effects-common-lib / effects-common-lib (pull_request) Has been cancelled
checks-deployment-tf-incus-hosts / deployment-tf-incus-hosts (pull_request) Has been cancelled
checks-deployment-tf-hosts / deployment-tf-hosts (pull_request) Has been cancelled
checks-apps-tf / apps-tf (pull_request) Has been cancelled
nix-unit-effects-tf-common-conversion / effects-tf-common-conversion (pull_request) Has been cancelled
nix-unit-lib-data-model / lib-data-model (pull_request) Has been cancelled
nix-unit-lib-function / lib-function (pull_request) Has been cancelled
nix-unit-lib-lib / lib-lib (pull_request) Has been cancelled
nixosConfigurations-hosting-provider-combined / hosting-provider-combined (pull_request) Has been cancelled
nixosConfigurations-hosting-provider-terraform-backend / hosting-provider-terraform-backend (pull_request) Has been cancelled
to e56610d661
Some checks failed
Nix flake completeness check / _complete (pull_request) Successful in 12s
checks-deployment-nixos-hosts / deployment-nixos-hosts (pull_request) Successful in 19s
checks-deployment-tf-incus-hosts / deployment-tf-incus-hosts (pull_request) Successful in 12m12s
checks-pre-commit / pre-commit (pull_request) Failing after 6s
devShells-default / default (pull_request) Successful in 6s
flake-show / apps-ssh (pull_request) Successful in 47s
nix-unit-effects-common-lib / effects-common-lib (pull_request) Successful in 8s
nix-unit-effects-tf-common-conversion / effects-tf-common-conversion (pull_request) Successful in 8s
nix-unit-lib-data-model / lib-data-model (pull_request) Successful in 10s
checks-deployment-ssh-hosts / deployment-ssh-hosts (pull_request) Successful in 13m59s
nix-unit-lib-function / lib-function (pull_request) Successful in 8s
nixosConfigurations-hosting-provider-combined / hosting-provider-combined (pull_request) Successful in 2s
nixosConfigurations-hosting-provider-terraform-backend / hosting-provider-terraform-backend (pull_request) Successful in 2s
nix-unit-lib-lib / lib-lib (pull_request) Successful in 7s
checks-apps-tf-incus / apps-tf-incus (pull_request) Successful in 15m17s
checks-deployment-tf-hosts / deployment-tf-hosts (pull_request) Successful in 16m10s
checks-apps-panel / apps-panel (pull_request) Has been cancelled
checks-apps-tf / apps-tf (pull_request) Has been cancelled
2026-05-23 22:52:04 +02:00
Compare
kiara changed title from WIP: checks: switch to hosting-provider terraform-backend wrapper to checks: switch to hosting-provider terraform-backend wrapper 2026-05-23 22:52:52 +02:00
checks/apps/tf: fix nixfmt indentation
All checks were successful
Nix flake completeness check / _complete (pull_request) Successful in 12s
checks-deployment-nixos-hosts / deployment-nixos-hosts (pull_request) Successful in 39s
checks-pre-commit / pre-commit (pull_request) Successful in 5s
devShells-default / default (pull_request) Successful in 5s
flake-show / apps-ssh (pull_request) Successful in 39s
nix-unit-effects-common-lib / effects-common-lib (pull_request) Successful in 7s
nix-unit-effects-tf-common-conversion / effects-tf-common-conversion (pull_request) Successful in 3s
nix-unit-lib-data-model / lib-data-model (pull_request) Successful in 3s
nix-unit-lib-function / lib-function (pull_request) Successful in 3s
nix-unit-lib-lib / lib-lib (pull_request) Successful in 3s
nixosConfigurations-hosting-provider-combined / hosting-provider-combined (pull_request) Successful in 2s
nixosConfigurations-hosting-provider-terraform-backend / hosting-provider-terraform-backend (pull_request) Successful in 2s
checks-apps-tf / apps-tf (pull_request) Successful in 13m15s
checks-deployment-ssh-hosts / deployment-ssh-hosts (pull_request) Successful in 13m56s
checks-apps-tf-incus / apps-tf-incus (pull_request) Successful in 15m10s
checks-deployment-tf-hosts / deployment-tf-hosts (pull_request) Successful in 16m40s
checks-deployment-tf-incus-hosts / deployment-tf-incus-hosts (pull_request) Successful in 34m7s
checks-apps-panel / apps-panel (pull_request) Successful in 23m51s
3b9ce1381a
Assisted-by: Claude:claude-sonnet-4-6
panel-wamp: add StateDirectory so /var/lib/panel exists before chdir
All checks were successful
Nix flake completeness check / _complete (pull_request) Successful in 12s
checks-deployment-nixos-hosts / deployment-nixos-hosts (pull_request) Successful in 19s
checks-apps-tf / apps-tf (pull_request) Successful in 13m0s
checks-panel-basic / panel-basic (pull_request) Successful in 48s
checks-pre-commit / pre-commit (pull_request) Successful in 5s
devShells-default / default (pull_request) Successful in 5s
checks-deployment-ssh-hosts / deployment-ssh-hosts (pull_request) Successful in 14m20s
nix-unit-effects-common-lib / effects-common-lib (pull_request) Successful in 7s
flake-show / apps-ssh (pull_request) Successful in 36s
nix-unit-effects-tf-common-conversion / effects-tf-common-conversion (pull_request) Successful in 7s
nix-unit-lib-data-model / lib-data-model (pull_request) Successful in 7s
checks-apps-tf-incus / apps-tf-incus (pull_request) Successful in 14m55s
nix-unit-lib-function / lib-function (pull_request) Successful in 7s
nixosConfigurations-hosting-provider-combined / hosting-provider-combined (pull_request) Successful in 2s
nix-unit-lib-lib / lib-lib (pull_request) Successful in 6s
nixosConfigurations-hosting-provider-panel / hosting-provider-panel (pull_request) Successful in 2s
nixosConfigurations-hosting-provider-terraform-backend / hosting-provider-terraform-backend (pull_request) Successful in 2s
checks-deployment-tf-hosts / deployment-tf-hosts (pull_request) Successful in 16m41s
checks-apps-panel / apps-panel (pull_request) Successful in 27m3s
checks-deployment-tf-incus-hosts / deployment-tf-incus-hosts (pull_request) Successful in 34m57s
bf713259d9
`panel-wamp.service` sets `WorkingDirectory = /var/lib/panel` but had no
`StateDirectory`, so systemd's CHDIR would fail on the first few start
attempts (before `panel.service` created the directory via its own
`StateDirectory`).  The repeated restarts delayed `_sse_bridge_manager`
from running, causing the test-suite deployment poll to time out.

Assisted-by: Claude:claude-opus-4-7
kiara merged commit 93e840c5a0 into main 2026-05-24 08:08:28 +02:00
Sign in to join this conversation.
No reviewers
fediversity/developers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
fediversity/fediversity!994
No description provided.