fediversity/fediversity
17
2
Fork
You've already forked fediversity
 10
Code Issues 96 Pull requests 24 Projects 1 Activity Actions 5

specify _class module attributes to explicitly declare module types #398

Merged
kiara merged 1 commit from kiara/fediversity:declare-classes into main 2025-06-23 17:24:55 +02:00
Conversation 1 Commits 1 Files changed 60 +118
kiara commented 2025-06-21 08:25:40 +02:00
Owner
Copy link

closes #93.

note that this includes classes:

  • nixos
  • nixosTest
  • nixops4Resource
  • nixops4Deployment

.. and my (made-up, as per the docs):

  • nix-unit
  • package

.. while i did not manage to cover:

  • service tests, given pkgs.nixosTest seemed to not actually like _class = "nixosTest" (?!)

... nor #93's mentioned destructured arguments for that matter, as per Fediversity/Fediversity#93 (comment) - let me know if that is still desired as well.

closes #93. note that this includes classes: - `nixos` - `nixosTest` - `nixops4Resource` - `nixops4Deployment` .. and my (made-up, as per the [docs](https://ryantm.github.io/nixpkgs/module-system/module-system/#module-system-lib-evalModules-param-class)): - `nix-unit` - `package` .. while i did not manage to cover: - service tests, given `pkgs.nixosTest` seemed to not actually like `_class = "nixosTest"` (?!) ... nor #93's mentioned destructured arguments for that matter, as per https://git.fediversity.eu/Fediversity/Fediversity/issues/93#issuecomment-8045 - let me know if that is still desired as well.
👍 1
kiara force-pushed declare-classes from c9b4301c70
Some checks failed
/ check-pre-commit (pull_request) Successful in 13s
Details
/ check-data-model (pull_request) Successful in 19s
Details
/ check-peertube (pull_request) Failing after 4s
Details
/ check-panel (pull_request) Successful in 1m23s
Details
/ check-deployment-basic (pull_request) Failing after 3s
Details
/ check-deployment-cli (pull_request) Failing after 4s
Details
/ check-deployment-panel (pull_request) Failing after 5s
Details
to 3f63ca75d1
All checks were successful
/ check-pre-commit (pull_request) Successful in 12s
Details
/ check-data-model (pull_request) Successful in 19s
Details
/ check-peertube (pull_request) Successful in 21s
Details
/ check-panel (pull_request) Successful in 1m21s
Details
/ check-deployment-basic (pull_request) Successful in 11m21s
Details
/ check-deployment-cli (pull_request) Successful in 38m16s
Details
/ check-deployment-panel (pull_request) Successful in 41m40s
Details
2025-06-21 09:13:55 +02:00 Compare
kiara force-pushed declare-classes from 3f63ca75d1
All checks were successful
/ check-pre-commit (pull_request) Successful in 12s
Details
/ check-data-model (pull_request) Successful in 19s
Details
/ check-peertube (pull_request) Successful in 21s
Details
/ check-panel (pull_request) Successful in 1m21s
Details
/ check-deployment-basic (pull_request) Successful in 11m21s
Details
/ check-deployment-cli (pull_request) Successful in 38m16s
Details
/ check-deployment-panel (pull_request) Successful in 41m40s
Details
to b53cdd761a
All checks were successful
/ check-pre-commit (pull_request) Successful in 13s
Details
/ check-data-model (pull_request) Successful in 17s
Details
/ check-peertube (pull_request) Successful in 20s
Details
/ check-panel (pull_request) Successful in 1m23s
Details
/ check-deployment-basic (pull_request) Successful in 11m37s
Details
/ check-deployment-cli (pull_request) Successful in 39m3s
Details
/ check-deployment-panel (pull_request) Successful in 42m9s
Details
2025-06-22 20:04:55 +02:00 Compare
kiara force-pushed declare-classes from b53cdd761a
All checks were successful
/ check-pre-commit (pull_request) Successful in 13s
Details
/ check-data-model (pull_request) Successful in 17s
Details
/ check-peertube (pull_request) Successful in 20s
Details
/ check-panel (pull_request) Successful in 1m23s
Details
/ check-deployment-basic (pull_request) Successful in 11m37s
Details
/ check-deployment-cli (pull_request) Successful in 39m3s
Details
/ check-deployment-panel (pull_request) Successful in 42m9s
Details
to 109ce6a513
All checks were successful
/ check-pre-commit (pull_request) Successful in 14s
Details
/ check-data-model (pull_request) Successful in 20s
Details
/ check-peertube (pull_request) Successful in 21s
Details
/ check-panel (pull_request) Successful in 1m29s
Details
/ check-deployment-basic (pull_request) Successful in 11m32s
Details
/ check-deployment-cli (pull_request) Successful in 39m10s
Details
/ check-deployment-panel (pull_request) Successful in 41m50s
Details
2025-06-22 20:07:06 +02:00 Compare
kiara force-pushed declare-classes from 109ce6a513
All checks were successful
/ check-pre-commit (pull_request) Successful in 14s
Details
/ check-data-model (pull_request) Successful in 20s
Details
/ check-peertube (pull_request) Successful in 21s
Details
/ check-panel (pull_request) Successful in 1m29s
Details
/ check-deployment-basic (pull_request) Successful in 11m32s
Details
/ check-deployment-cli (pull_request) Successful in 39m10s
Details
/ check-deployment-panel (pull_request) Successful in 41m50s
Details
to 40a25beb4d
Some checks failed
/ check-pre-commit (pull_request) Has been cancelled
Details
/ check-data-model (pull_request) Has been cancelled
Details
/ check-peertube (pull_request) Has been cancelled
Details
/ check-panel (pull_request) Has been cancelled
Details
/ check-deployment-basic (pull_request) Has been cancelled
Details
/ check-deployment-cli (pull_request) Has been cancelled
Details
/ check-deployment-panel (pull_request) Has been cancelled
Details
2025-06-23 17:24:48 +02:00 Compare
kiara merged commit 9a25a04bfa into main 2025-06-23 17:24:55 +02:00
kiara deleted branch declare-classes 2025-06-23 17:24:56 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
fricklerhandwerk
Labels
Clear labels   
0 points
fibonacci complexity: 0 points

  
0.5 points
fibonacci complexity: 0.5 points

  
1 point
fibonacci complexity: 1 point

  
13 points
fibonacci complexity: 13 points

  
2 points
fibonacci complexity: 2 points

  
21 points
fibonacci complexity: 21 points

  
3 points
fibonacci complexity: 3 points

  
34 points
fibonacci complexity: 34 points

  
5 points
fibonacci complexity: 5 points

  
55 points
fibonacci complexity: 55 points

  
8 points
fibonacci complexity: 8 points

  
ambition
application-offering

  
ambition
configure-applications

  
ambition
front-end

  
ambition/install-applications
  
ambition
security

  
ambition
switch-host

  
ambition
update-applications

  
ambition
user-management

  
api service
features that may relate more to a (to be created) API service

  
blocked

   
component: fediversity panel

   
component: nixops4

   
documentation

   
estimation high: >3d

   
estimation low: <2h

   
estimation mid: <8h

   
infinite points
fibonacci complexity: infinite points

  
productisation
features out-scoped with the decoupling of the productisation effort

  
project-management
Project management related tasks

  
question

   
role: application developer

   
role: application operator

   
role: hosting provider

   
role: maintainer

   
security

   
technical debt

   
testing

   
type unclear

   
type: bug
Anything that doesn't work as advertised

  
type: deliverable

   
type: key result

   
type: objective

   
type: task

   
type: user story

   
user experience
No labels
0 points
0.5 points
1 point
13 points
2 points
21 points
3 points
34 points
5 points
55 points
8 points
ambition
application-offering
ambition
configure-applications
ambition
front-end
ambition/install-applications
ambition
security
ambition
switch-host
ambition
update-applications
ambition
user-management
api service
blocked
component: fediversity panel
component: nixops4
documentation
estimation high: >3d
estimation low: <2h
estimation mid: <8h
infinite points
productisation
project-management
question
role: application developer
role: application operator
role: hosting provider
role: maintainer
security
technical debt
testing
type unclear
type: bug
type: deliverable
type: key result
type: objective
type: task
type: user story
user experience
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
fricklerhandwerk
Niols
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
fediversity/fediversity!398
No description provided.