fediversity/fediversity
Watch
18
2
Fork
You've already forked fediversity
 10
Code Issues 100 Pull requests 17 Projects Activity Actions

name paths for purity, preventing double-hash store paths #346

Closed
kiara wants to merge 3 commits from kiara/fediversity:purge-double-hash into main
pull from: kiara/fediversity:purge-double-hash
merge into: fediversity:main
Conversation 4 Commits 3 Files changed 5 +22 -5
kiara commented 2025-05-30 16:59:31 +02:00
Owner
Copy link

see https://github.com/NixOS/nix/issues/10627

see https://github.com/NixOS/nix/issues/10627
name paths for purity, preventing double-hash store paths
Some checks failed
/ check-pre-commit (pull_request) Failing after 9s
Details
/ check-peertube (pull_request) Successful in 17s
Details
/ check-panel (pull_request) Failing after 10s
Details
/ check-deployment-basic (pull_request) Failing after 39s
Details
/ check-deployment-cli (pull_request) Failing after 37s
Details
196d4e1540
 
https://github.com/NixOS/nix/issues/10627
fricklerhandwerk commented 2025-06-02 09:56:48 +02:00
Owner
Copy link

Is this solving some issue we had?

Is this solving some issue we had?
kiara commented 2025-06-02 11:21:58 +02:00
Author
Owner
Copy link

@fricklerhandwerk this should be noticeable only after #92; the impurity makes it less cacheable as the hash would depend on the root directory name.
so no more urgent than that.

@fricklerhandwerk this should be noticeable only after #92; the impurity makes it less cacheable as the hash would depend on the root directory name. so no more urgent than that.
restore path for place that needed path over string
Some checks failed
/ check-pre-commit (pull_request) Successful in 13s
Details
/ check-peertube (pull_request) Successful in 18s
Details
/ check-panel (pull_request) Successful in 1m7s
Details
/ check-deployment-basic (pull_request) Successful in 29m39s
Details
/ check-deployment-cli (pull_request) Failing after 29m37s
Details
0930a8b75b
fricklerhandwerk force-pushed purge-double-hash from d4cbc915cd
Some checks failed
/ check-pre-commit (pull_request) Failing after 10s
Details
/ check-peertube (pull_request) Successful in 19s
Details
/ check-panel (pull_request) Successful in 1m5s
Details
/ check-deployment-cli (pull_request) Failing after 14m3s
Details
/ check-deployment-basic (pull_request) Failing after 14m5s
Details
to 0c30914acb
Some checks failed
/ check-pre-commit (pull_request) Failing after 8s
Details
/ check-peertube (pull_request) Successful in 17s
Details
/ check-panel (pull_request) Successful in 1m9s
Details
/ check-deployment-cli (pull_request) Failing after 11m57s
Details
/ check-deployment-basic (pull_request) Failing after 11m59s
Details
2025-06-11 18:27:55 +02:00 Compare
fricklerhandwerk force-pushed purge-double-hash from 0c30914acb
Some checks failed
/ check-pre-commit (pull_request) Failing after 8s
Details
/ check-peertube (pull_request) Successful in 17s
Details
/ check-panel (pull_request) Successful in 1m9s
Details
/ check-deployment-cli (pull_request) Failing after 11m57s
Details
/ check-deployment-basic (pull_request) Failing after 11m59s
Details
to 43c64debfc
Some checks failed
/ check-pre-commit (pull_request) Failing after 8s
Details
/ check-peertube (pull_request) Successful in 16s
Details
/ check-deployment-cli (pull_request) Failing after 11m37s
Details
/ check-deployment-basic (pull_request) Failing after 11m39s
Details
/ check-panel (pull_request) Failing after 11m41s
Details
2025-06-11 18:28:16 +02:00 Compare
fricklerhandwerk force-pushed purge-double-hash from 43c64debfc
Some checks failed
/ check-pre-commit (pull_request) Failing after 8s
Details
/ check-peertube (pull_request) Successful in 16s
Details
/ check-deployment-cli (pull_request) Failing after 11m37s
Details
/ check-deployment-basic (pull_request) Failing after 11m39s
Details
/ check-panel (pull_request) Failing after 11m41s
Details
to 5e887094c3
Some checks failed
/ check-pre-commit (pull_request) Failing after 7s
Details
/ check-peertube (pull_request) Successful in 16s
Details
/ check-deployment-cli (pull_request) Failing after 11m5s
Details
/ check-deployment-basic (pull_request) Failing after 11m7s
Details
/ check-panel (pull_request) Failing after 11m9s
Details
2025-06-11 18:28:48 +02:00 Compare
fricklerhandwerk commented 2025-06-11 18:31:29 +02:00
Owner
Copy link

I really don't know whether the decrease in readability is worth the questionable increase in caching. I see that for shell.nix it would slightly improve the situation if a contributor happened to change the containing directory's name, but otherwise? @Niols Is the double-hashed-storepath actually a thing for the deployment test? Or could the explicit store path name be isolated to just the test code? Would it maybe get solved by moving the test flakes to the VM test rather than re-using the main flake?

I really don't know whether the decrease in readability is worth the questionable increase in caching. I see that for `shell.nix` it would slightly improve the situation if a contributor happened to change the containing directory's name, but otherwise? @Niols Is the double-hashed-storepath actually a thing for the deployment test? Or could the explicit store path name be isolated to just the test code? Would it maybe get solved by moving the test flakes to the VM test rather than re-using the main flake?
kiara commented 2025-06-11 18:42:25 +02:00
Author
Owner
Copy link

i do suppose even if top-level caching is beaten by this, caching of dependency derivations should be fine still, so i'd be okay with closing if preferred

i do suppose even if top-level caching is beaten by this, caching of dependency derivations should be fine still, so i'd be okay with closing if preferred
👍 1
fricklerhandwerk closed this pull request 2025-06-11 21:30:03 +02:00
Some checks failed
/ check-pre-commit (pull_request) Failing after 7s
Details
/ check-peertube (pull_request) Successful in 16s
Details
/ check-deployment-cli (pull_request) Failing after 11m5s
Details
/ check-deployment-basic (pull_request) Failing after 11m7s
Details
/ check-panel (pull_request) Failing after 11m9s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
0 points
fibonacci complexity: 0 points

  
0.5 points
fibonacci complexity: 0.5 points

  
1 point
fibonacci complexity: 1 point

  
13 points
fibonacci complexity: 13 points

  
2 points
fibonacci complexity: 2 points

  
21 points
fibonacci complexity: 21 points

  
3 points
fibonacci complexity: 3 points

  
34 points
fibonacci complexity: 34 points

  
5 points
fibonacci complexity: 5 points

  
55 points
fibonacci complexity: 55 points

  
8 points
fibonacci complexity: 8 points

  
ambition
application-offering

  
ambition
configure-applications

  
ambition
front-end

  
ambition/install-applications
  
ambition
security

  
ambition
switch-host

  
ambition
update-applications

  
ambition
user-management

  
api service
features that may relate more to a (to be created) API service

  
blocked

   
component: fediversity panel

   
component: nixops4

   
documentation

   
estimation high: >3d

   
estimation low: <2h

   
estimation mid: <8h

   
infinite points
fibonacci complexity: infinite points

  
productisation
features out-scoped with the decoupling of the productisation effort

  
project-management
Project management related tasks

  
question

   
role: application developer

   
role: application operator

   
role: hosting provider

   
role: maintainer

   
security

   
technical debt

   
testing

   
type unclear

   
type: bug
Anything that doesn't work as advertised

  
type: deliverable

   
type: key result

   
type: objective

   
type: task

   
type: user story

   
user experience
No labels
0 points
0.5 points
1 point
13 points
2 points
21 points
3 points
34 points
5 points
55 points
8 points
ambition
application-offering
ambition
configure-applications
ambition
front-end
ambition/install-applications
ambition
security
ambition
switch-host
ambition
update-applications
ambition
user-management
api service
blocked
component: fediversity panel
component: nixops4
documentation
estimation high: >3d
estimation low: <2h
estimation mid: <8h
infinite points
productisation
project-management
question
role: application developer
role: application operator
role: hosting provider
role: maintainer
security
technical debt
testing
type unclear
type: bug
type: deliverable
type: key result
type: objective
type: task
type: user story
user experience
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
fediversity/fediversity!346
No description provided.