Progress Indicator #259
No reviewers
Labels
No labels
ambition
application-offering
ambition
configure-applications
ambition
front-end
ambition/install-applications
ambition
security
ambition
switch-host
ambition
update-applications
ambition
user-management
blocked
component
api-service
component
fediversity-panel
component
nixops4
documentation
points
0
points
0.5
points
1
points
13
points
2
points
21
points
3
points
34
points
5
points
55
points
8
points
infinite
productisation
project-management
question
role
application-developer
role
application-operator
role
hosting-provider
role
maintainer
security
technical debt
testing
type
bug
type
deliverable
type
key-result
type
objective
type
task
type
unclear
type
user-story
user experience
No milestone
No project
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
fediversity/fediversity!259
Loading…
Reference in a new issue
No description provided.
Delete branch "lois/Fediversity:ProgressIndicator"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
closes #74
Show progress indicator to track deployment
WIP: Progress Indicatorto Progress Indicator@ -6,1 +6,4 @@{{ form.as_p }}<button id="deploy-button" class="button"hx-post="{% url 'configuration_form' %}"hx-trigger="click"do they not use click as a default trigger for buttons? (i haven't checked)
even if default wouldn't be better to still specify things like this so its clear to other people working on this code what it triggers on since we lack comments through the whole code
please clean the diffs to ensure this isn't reverting stuff, otherwise lgtm
@ -7,0 +8,4 @@hx-post="{% url 'configuration_form' %}"hx-trigger="click"hx-indicator="#spinner-container"hx-vals='{"deploy": ""}'i wonder if there's a more elegant way to handle button identity here, but i'm no htmx expert and i guess this matches with what django wanted now 🤷♀️
@ -8,7 +10,10 @@ from django.contrib.auth.models import Userfrom django.views.generic import TemplateView, DetailViewfrom django.views.generic.edit import FormViewfrom panel import models, settingsthis now reverts some of the logic from Fediversity/Fediversity#253/files 😿, please check your diffs to ensure any proposed change matches your intention
@kiara i cleaned up somethings in the file to improve the diff
@ -128,0 +125,4 @@cwd=settings.repo_dir,env=env,)maybe factor this block into a separate function, maybe located just under where this block had been to reduce merge conflicts for now - otherwise i'm satisfied 😅
@ -7,0 +10,4 @@hx-indicator="#spinner-container"hx-disabled-elt="this"hx-swap="none"name="deploy"hm, def a nitpick, but it feels unfortunate forgejo highlighting breaks on these lines.
i think
namewas highlighted when it was up still.could it be it breaks for everything starting from the line containing the percentage symbols, and if so would reordering help? tho it could also dislike newlines between attributes or attribute names with dashes... could we find a nice middle ground here?
@ -129,0 +105,4 @@return objdef convert_enums_to_names(self, data_dict):this looks like a lot of extra code for a spinner
@ -5,6 +5,7 @@<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /><meta http-equiv="X-UA-Compatible" content="IE=edge" /><meta name="viewport" content="width=device-width, initial-scale=1" /><script src="https://unpkg.com/htmx.org@2.0.4" integrity="sha384-HGfztofotfshcF7+8n44JQL2oJmowVChPTg48S+jvZoztPfvwD79OC/LTtG6dMp+" crossorigin="anonymous"></script>Please use our local one here
@ -129,0 +92,4 @@class DeploymentStatus(ConfigurationForm):def form_valid(self, form):obj = self.get_object()obj.value = form.to_python().model_dump_json()Why are we reading and then immediately writing the object here? This was done in the form to store the user input. I would have expected the deployment button to load the stored config from the DB and run nixops with the values.
fba4ab090c772901085b@ -129,0 +121,4 @@}cmd = ["nix","develop",as per diffchecker, the main branch had a comment in here:
# workaround to pass in info to nixops4 thru env vars, tho impure :(@ -37,3 +37,3 @@mastodon_enable=True,)print(form_data)please remove all print statements. if you want debug logging, use python's logging infrastructure