removeAtPath: teach the schema prune oneOf/anyOf #1504

New issue

Open

opened 2026-08-20 13:55:12 +02:00 by kiara · 0 comments

kiara commented

2026-08-20 13:55:12 +02:00

Owner

Follow-up split out of the work on #629.

core/lib/schema-for-source.nix prunes the legacy side of every recovered rename out of the emitted schema, so an alias node does not become a form field (and, inside an attrsOf, does not land in required). removeAtPath walks properties and, since #629, a wildcard step through additionalProperties/items.

It does not walk oneOf/anyOf, and the deployment-method attrTag union emits each branch at oneOf[i].properties.<tag> rather than as properties. So a from path under deployment-method prunes nothing: the node stays in the served schema. There is a TODO at prunePaths recording this.

No rename lands under deployment-method today, which is why this is a gap rather than a bug. It closes by having removeAtPath descend each branch of a oneOf/anyOf and apply the same step, no-opping in the branches where the head is absent.

Follow-up split out of the work on #629. `core/lib/schema-for-source.nix` prunes the legacy side of every recovered rename out of the emitted schema, so an alias node does not become a form field (and, inside an `attrsOf`, does not land in `required`). `removeAtPath` walks `properties` and, since #629, a wildcard step through `additionalProperties`/`items`. It does not walk `oneOf`/`anyOf`, and the `deployment-method` `attrTag` union emits each branch at `oneOf[i].properties.<tag>` rather than as `properties`. So a `from` path under `deployment-method` prunes nothing: the node stays in the served schema. There is a `TODO` at `prunePaths` recording this. No rename lands under `deployment-method` today, which is why this is a gap rather than a bug. It closes by having `removeAtPath` descend each branch of a `oneOf`/`anyOf` and apply the same step, no-opping in the branches where the head is absent.

kiara referenced this issue

2026-08-20 14:08:40 +02:00

core/lib: carry a stored configuration across renames no single pin declares #1506

kiara referenced this issue from fediversity/nix-module-form

2026-10-01 00:19:47 +02:00

Handle renames inside tagged unions and reused retired names #43

kiara added a new dependency

2026-10-01 17:30:19 +02:00

#629 schema updates automated