Fediversity/Fediversity
13
2
Fork 6
Code Issues 111 Pull requests 16 Projects 1 Activity Actions

Grab git-hooks from npins #448

Merged
Niols merged 1 commit from Niols/Fediversity:git-hooks-npins into main 2025-07-09 13:21:50 +02:00
Conversation 4 Commits 1 Files changed 4 +8 -84
Niols commented 2025-07-08 14:03:26 +02:00
Owner
Copy link

This PR builds on top of #447 and will be subject to the same discussion. Let's discuss there whether it makes sense to get rid of the flake-parts and git-hooks flake inputs.

This PR builds on top of #447 and will be subject to the same discussion. Let's discuss there whether it makes sense to get rid of the `flake-parts` and `git-hooks` flake inputs.
Niols added 4 commits 2025-07-08 14:03:27 +02:00
Get rid of flake dependency on flake-parts - grab it from npins
Some checks failed
/ check-data-model (pull_request) Successful in 31s
Details
/ check-peertube (pull_request) Successful in 21s
Details
/ check-panel (pull_request) Successful in 1m28s
Details
/ check-deployment-basic (pull_request) Successful in 11m37s
Details
/ check-deployment-cli (pull_request) Successful in 40m29s
Details
/ check-pre-commit (pull_request) Successful in 13s
Details
/ check-deployment-panel (pull_request) Has been cancelled
Details
e9f7409ed0
Also define systems in mkFlake.nix
All checks were successful
/ check-pre-commit (pull_request) Successful in 14s
Details
/ check-data-model (pull_request) Successful in 30s
Details
/ check-peertube (pull_request) Successful in 21s
Details
/ check-panel (pull_request) Successful in 1m31s
Details
/ check-deployment-basic (pull_request) Successful in 11m14s
Details
/ check-deployment-cli (pull_request) Successful in 39m1s
Details
/ check-deployment-panel (pull_request) Successful in 43m7s
Details
f7a55963ec
Grab git-hooks from npins
Some checks failed
/ check-pre-commit (pull_request) Successful in 17s
Details
/ check-data-model (pull_request) Successful in 37s
Details
/ check-peertube (pull_request) Successful in 25s
Details
/ check-panel (pull_request) Successful in 1m35s
Details
/ check-deployment-basic (pull_request) Failing after 7m10s
Details
/ check-deployment-cli (pull_request) Failing after 7m37s
Details
/ check-deployment-panel (pull_request) Failing after 8m23s
Details
a6b6d66292
kiara approved these changes 2025-07-08 17:55:52 +02:00
kiara commented 2025-07-08 18:08:42 +02:00
Owner
Copy link

the CI error seems:

deployer # … while fetching the input 'dcf5072734.tar.gz'
deployer #
deployer # error: Failed to open archive (Source threw exception: error: unable to download 'dcf5072734.tar.gz': Could not resolve hostname (6) Could not resolve host: github.com)

not sure why that'd fail only in CI tho.

the CI error seems: > deployer # … while fetching the input 'https://github.com/cachix/git-hooks.nix/archive/dcf5072734cb576d2b0c59b2ac44f5050b5eac82.tar.gz' > deployer # > deployer # error: Failed to open archive (Source threw exception: error: unable to download 'https://github.com/cachix/git-hooks.nix/archive/dcf5072734cb576d2b0c59b2ac44f5050b5eac82.tar.gz': Could not resolve hostname (6) Could not resolve host: github.com) not sure why that'd fail only in CI tho.
Niols commented 2025-07-09 09:54:42 +02:00
Author
Owner
Copy link

I don't understand. It is not a fluke, I ran CI again and it failed in the same way. Let's first see if we merge #447, then I'll rebase this one, and then I'll investigate!

I don't understand. It is not a fluke, I ran CI again and it failed in the same way. Let's first see if we merge #447, then I'll rebase this one, and then I'll investigate!
Niols force-pushed git-hooks-npins from a6b6d66292 to 9343bf8398 2025-07-09 10:21:31 +02:00 Compare
Niols commented 2025-07-09 10:31:21 +02:00
Author
Owner
Copy link

OK, I rebased, and I can reproduce locally. I wonder what I did wrong the first time, and what I did right in #449 for the problem not to show up. I will figure it out.

OK, I rebased, and I can reproduce locally. I wonder what I did wrong the first time, and what I did right in #449 for the problem not to show up. I will figure it out.
Niols force-pushed git-hooks-npins from 9343bf8398 to de5c5970d9 2025-07-09 11:01:41 +02:00 Compare
Niols commented 2025-07-09 11:02:04 +02:00
Author
Owner
Copy link

OK, now this should be good! I still don't understand exactly what I did wrong here and right in #449, but I'm just glad this seems fixed.

OK, now this should be good! I still don't understand exactly what I did wrong here and right in #449, but I'm just glad this seems fixed.
fricklerhandwerk reviewed 2025-07-09 11:24:28 +02:00
deployment/check/common/deployerNode.nix Outdated
@ -64,3 +62,4 @@
pkgs.stdenv
pkgs.stdenvNoCC
]
++ attrValues sources
fricklerhandwerk commented 2025-07-09 11:24:28 +02:00
Owner
Copy link

Not exactly convinced we should give carte blanche here as it may bloat the closure, I'd at least wish for a comment that reassures us this is a good idea.

I imagine it may be okay because we're almost certainly going to need exactly the project's production source closure. But given we may want to add development dependencies we may in fact need less, asymptotically. Today I've been contemplating how to cleanly separate dev and prod dependencies, but it still needs time to cook.

Not exactly convinced we should give carte blanche here as it may bloat the closure, I'd at least wish for a comment that reassures us this is a good idea. I imagine it may be okay because we're almost certainly going to need exactly the project's production source closure. But given we may want to add development dependencies we may in fact need less, asymptotically. Today I've been contemplating how to cleanly separate dev and prod dependencies, but it still needs time to cook.
❤️ 1
Niols commented 2025-07-09 11:32:36 +02:00
Author
Owner
Copy link

Fair enough. In the meantime, would you prefer 328bf9ffed, which seems to also pass locally?

Fair enough. In the meantime, would you prefer https://git.fediversity.eu/Niols/Fediversity/commit/328bf9ffedf95845d8f9e6a280859b5d9beaef54, which seems to also pass locally?
👍 1
Niols commented 2025-07-09 11:43:59 +02:00
Author
Owner
Copy link

Done in 7fe48a28ca.

Done in 7fe48a28ca.
👍 1
fricklerhandwerk marked this conversation as resolved
Niols force-pushed git-hooks-npins from de5c5970d9 to 7fe48a28ca 2025-07-09 11:43:22 +02:00 Compare
Niols merged commit 1d40dcfc0e into main 2025-07-09 13:21:50 +02:00
Niols deleted branch git-hooks-npins 2025-07-09 13:21:50 +02:00
Niols referenced this pull request from a commit 2025-07-09 13:21:51 +02:00
Grab `git-hooks` from npins (#448)
Niols referenced this pull request from a commit 2025-07-09 15:07:05 +02:00
Unflakify deployment tests (#449)
Sign in to join this conversation.
Reviewers
No reviewers
kiara
Labels
Clear labels   
api service

features that may relate more to a (to be created) API service

  
blocked

   
bug

Anything that doesn't work as advertised

  
component: fediversity panel

   
component: nixops4

   
documentation

   
estimation high: >3d

   
estimation low: <2h

   
estimation mid: <8h

   
productisation

features out-scoped with the decoupling of the productisation effort

  
project-management

Project management related tasks

  
question

   
role: sysadmin

   
security

   
technical debt

   
testing

   
type unclear

   
type: key result

   
type: objective

   
type: task

   
type: user story

   
user experience
No labels
api service
blocked
bug
component: fediversity panel
component: nixops4
documentation
estimation high: >3d
estimation low: <2h
estimation mid: <8h
productisation
project-management
question
role: sysadmin
security
technical debt
testing
type unclear
type: key result
type: objective
type: task
type: user story
user experience
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Fediversity/Fediversity#448
No description provided.
Delete branch "Niols/Fediversity:git-hooks-npins"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?