fediversity/fediversity
13
2
Fork 6
Code Issues 162 Pull requests 30 Projects 1 Activity Actions

fix relative path computation #38

Merged
fricklerhandwerk merged 1 commit from fricklerhandwerk/Fediversity:fix-nav-bug into main 2024-11-28 09:45:15 +01:00
Conversation 4 Commits 1 Files changed 2 +21 -9
fricklerhandwerk commented 2024-11-27 14:53:24 +01:00
Owner
Copy link

this unbreaks navigation in nested pages

this unbreaks navigation in nested pages
fix relative path computation
All checks were successful
/ check-pre-commit (pull_request) Successful in 23s
Details
d4f7d17768
requested review from Niols 2024-11-27 14:53:31 +01:00
Niols approved these changes 2024-11-27 15:07:22 +01:00
Niols commented 2024-11-27 17:15:23 +01:00
Owner
Copy link

If there are tests, should CI run them?

If there are tests, should CI run them?
Niols commented 2024-11-27 17:16:50 +01:00
Owner
Copy link

Also, the CI could try to build the website, just to check that that does work. In the far future, we can imagine going for CD of the website from the CI pipeline, but for now that would be a start.

Also, the CI could try to build the website, just to check that that does work. In the far future, we can imagine going for CD of the website from the CI pipeline, but for now that would be a start.
👍 1
fricklerhandwerk deleted branch fix-nav-bug 2024-11-28 09:45:16 +01:00
fricklerhandwerk commented 2024-11-28 09:45:42 +01:00
Author
Owner
Copy link

Yes, absolutely, tests and builds should be run in CI.

Yes, absolutely, tests and builds should be run in CI.
Sign in to join this conversation.
Reviewers
No reviewers
Niols
Labels
Clear labels   
0 points

fibonacci complexity: 0 points

  
0.5 points

fibonacci complexity: 0.5 points

  
1 point

fibonacci complexity: 1 point

  
13 points

fibonacci complexity: 13 points

  
2 points

fibonacci complexity: 2 points

  
21 points

fibonacci complexity: 21 points

  
3 points

fibonacci complexity: 3 points

  
34 points

fibonacci complexity: 34 points

  
5 points

fibonacci complexity: 5 points

  
55 points

fibonacci complexity: 55 points

  
8 points

fibonacci complexity: 8 points

  
api service

features that may relate more to a (to be created) API service

  
blocked

   
component: fediversity panel

   
component: nixops4

   
documentation

   
estimation high: >3d

   
estimation low: <2h

   
estimation mid: <8h

   
infinite points

fibonacci complexity: infinite points

  
productisation

features out-scoped with the decoupling of the productisation effort

  
project-management

Project management related tasks

  
question

   
role: application developer

   
role: application operator

   
role: hosting provider

   
role: maintainer

   
security

   
technical debt

   
testing

   
type unclear

   
type: bug

Anything that doesn't work as advertised

  
type: deliverable

   
type: key result

   
type: objective

   
type: task

   
type: user story

   
user experience
No labels
0 points
0.5 points
1 point
13 points
2 points
21 points
3 points
34 points
5 points
55 points
8 points
api service
blocked
component: fediversity panel
component: nixops4
documentation
estimation high: >3d
estimation low: <2h
estimation mid: <8h
infinite points
productisation
project-management
question
role: application developer
role: application operator
role: hosting provider
role: maintainer
security
technical debt
testing
type unclear
type: bug
type: deliverable
type: key result
type: objective
type: task
type: user story
user experience
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: fediversity/fediversity#38
No description provided.
Delete branch "fricklerhandwerk/Fediversity:fix-nav-bug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?