Fediversity/Fediversity
12
1
Fork 3
Code Issues 22 Pull requests 2 Actions Projects 1 Activity

fix relative path computation #38

Merged
fricklerhandwerk merged 1 commit from fricklerhandwerk/Fediversity:fix-nav-bug into main 2024-11-28 09:45:15 +01:00
Conversation 3 Commits 1 Files changed 2 +21 -9
fricklerhandwerk commented 2024-11-27 14:53:24 +01:00
Owner
Copy link

this unbreaks navigation in nested pages

this unbreaks navigation in nested pages
fricklerhandwerk added 1 commit 2024-11-27 14:53:26 +01:00
fix relative path computation
All checks were successful
/ check-pre-commit (pull_request) Successful in 23s
Details
d4f7d17768
fricklerhandwerk requested review from Niols 2024-11-27 14:53:31 +01:00
Niols approved these changes 2024-11-27 15:07:22 +01:00
Niols commented 2024-11-27 17:15:23 +01:00
Owner
Copy link

If there are tests, should CI run them?

If there are tests, should CI run them?
Niols commented 2024-11-27 17:16:50 +01:00
Owner
Copy link

Also, the CI could try to build the website, just to check that that does work. In the far future, we can imagine going for CD of the website from the CI pipeline, but for now that would be a start.

Also, the CI could try to build the website, just to check that that does work. In the far future, we can imagine going for CD of the website from the CI pipeline, but for now that would be a start.
👍 1
fricklerhandwerk merged commit f67c012dfe into main 2024-11-28 09:45:15 +01:00
fricklerhandwerk deleted branch fix-nav-bug 2024-11-28 09:45:16 +01:00
fricklerhandwerk commented 2024-11-28 09:45:42 +01:00
Author
Owner
Copy link

Yes, absolutely, tests and builds should be run in CI.

Yes, absolutely, tests and builds should be run in CI.
Sign in to join this conversation.
Reviewers
No reviewers
Niols
Labels
Clear labels   
blocked

   
project-management

Project management related tasks

  
question
No labels
blocked
project-management
question
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Fediversity/Fediversity#38
No description provided.
Delete branch "fricklerhandwerk/Fediversity:fix-nav-bug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?