Fediversity/Fediversity
12
1
Fork 3
Code Issues 22 Pull requests 2 Actions Projects 1 Activity

Cleanup and consolidate remaining configurations #23

Manually merged
Niols merged 4 commits from cleanup-consolidate-config into main 2024-11-21 12:14:46 +01:00
Conversation 0 Commits 4 Files changed 9 +51 -57
Niols commented 2024-11-20 17:47:16 +01:00
Owner
Copy link

This PR builds on top of #22. After all the factorisation brought by #19, #20, #21, and #22, I believe it is time to clean up the configurations; they should basically be a very simple default.nix module defining the procolix.vm options and some hardware stuff, and then potentially one or two files for service-specific configuration. There is some more factorisation that is doable (for instance, vm02179 and vm02186 both have a gitea-runner.nix configuration and they are very similar), but maybe I wait for all these PRs to be merged.

This PR builds on top of #22. After all the factorisation brought by #19, #20, #21, and #22, I believe it is time to clean up the configurations; they should basically be a very simple `default.nix` module defining the `procolix.vm` options and some hardware stuff, and then potentially one or two files for service-specific configuration. There is some more factorisation that is doable (for instance, vm02179 and vm02186 both have a `gitea-runner.nix` configuration and they are very similar), but maybe I wait for all these PRs to be merged.
Niols added 4 commits 2024-11-20 17:47:17 +01:00
Consolidate config for vm02187
All checks were successful
/ check-pre-commit (pull_request) Successful in 22s
Details
9f81ebffcb
fricklerhandwerk approved these changes 2024-11-20 23:21:35 +01:00
fricklerhandwerk left a comment
Owner
Copy link

yes, very nice!

yes, very nice!
Niols changed target branch from factorise-other-config to main 2024-11-21 12:12:29 +01:00
Niols force-pushed cleanup-consolidate-config from 9f81ebffcb to 5bc7f954bd 2024-11-21 12:14:09 +01:00 Compare
Niols manually merged commit da25f9221a into main 2024-11-21 12:14:46 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
fricklerhandwerk
Labels
Clear labels   
blocked

   
project-management

Project management related tasks

  
question
No labels
blocked
project-management
question
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Fediversity/Fediversity#23
No description provided.
Delete branch "cleanup-consolidate-config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?