Factorise hardware configurations #21

Closed

Niols wants to merge 8 commits from factorise-hardware-config into factorise-users-config

Niols commented

2024-11-20 17:43:47 +01:00

Owner

This PR merges all hardware-related configurations from VMs in infra/ into a infra/common/hardware.nix module. More factorisation will come in subsequent PRs. It builds on top of #20.

It is to be noted that hardware configurations vary between VMs, on mostly between vm02116 on one side and vm02179, vm02186 and vm02187 on the other. Namely:

vm02179, vm02186 and vm02187 all have imports = [ (modulesPath + "/profiles/qemu-guest.nix") ] while vm02116 doesn't.
vm02116 has to following kernel modules available: ata_piix, uhci_hcd, sr_mod, and xen_blkfront, while vm02179, vm02186 and vm02187 have the following: ata_piix, uhci_hcd, virtio_pci, virtio_scsi, sd_mod, and sr_mod.
vm02116 is the only one having: services.xe-guest-utilities.enable = true

I don't know anything about those things so I don't dare taking decisions and cleaning up. For now, all configurations share imports = [ (modulesPath + "/profiles/qemu-guest.nix") ] and all the kernel modules.

This PR merges all hardware-related configurations from VMs in `infra/` into a `infra/common/hardware.nix` module. More factorisation will come in subsequent PRs. It builds on top of #20. It is to be noted that hardware configurations vary between VMs, on mostly between vm02116 on one side and vm02179, vm02186 and vm02187 on the other. Namely: - vm02179, vm02186 and vm02187 all have `imports = [ (modulesPath + "/profiles/qemu-guest.nix") ]` while vm02116 doesn't. - vm02116 has to following kernel modules available: `ata_piix`, `uhci_hcd`, `sr_mod`, and `xen_blkfront`, while vm02179, vm02186 and vm02187 have the following: `ata_piix`, `uhci_hcd`, `virtio_pci`, `virtio_scsi`, `sd_mod`, and `sr_mod`. - vm02116 is the only one having: `services.xe-guest-utilities.enable = true` I don't know anything about those things so I don't dare taking decisions and cleaning up. For now, all configurations share `imports = [ (modulesPath + "/profiles/qemu-guest.nix") ]` and all the kernel modules.

Niols added 4 commits

2024-11-20 17:43:49 +01:00

Move hardware config of vm02116 to infra/common 3edc29b124

Factorise hardware config of vm02179 into infra/common 25a29c8644

Factorise hardware config of vm02186 into infra/common cecd8544ad

Factorise hardware config of vm02187 into infra/common

/ check-pre-commit (pull_request) Successful in 22s

Details

ddc2e8a21b

Niols referenced this pull request

2024-11-20 17:44:52 +01:00

Factorise other configuration options #22

Niols referenced this pull request

2024-11-20 17:47:16 +01:00

Cleanup and consolidate remaining configurations #23

fricklerhandwerk approved these changes

2024-11-20 23:04:51 +01:00

fricklerhandwerk left a comment

Owner

Makes sense, @koen should check though.

kevin commented

2024-11-21 10:32:57 +01:00

Owner

due vm02116 being one of the older fediversity vm's its still running on our old Xen vm environment so its running on completely different hardware

vm02179, vm02186 and vm02187 are allot newer and so they are running on an newer proxmox environment

all 4 vms will have to moved to the fediversity promox in the future

due vm02116 being one of the older fediversity vm's its still running on our old Xen vm environment so its running on completely different hardware vm02179, vm02186 and vm02187 are allot newer and so they are running on an newer proxmox environment all 4 vms will have to moved to the fediversity promox in the future

Niols closed this pull request

2024-11-21 11:54:14 +01:00

Niols referenced this pull request from a commit

2024-11-21 11:58:12 +01:00

Factorise hardware configurations (#21)

Niols commented

2024-11-21 11:58:31 +01:00

Author

Owner

Thank you for your comments. I have kept vm02116's specificities documented in the code.